-
Notifications
You must be signed in to change notification settings - Fork 45
feat(CLNP-3087): message threading #181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6b7734
to
1727b18
Compare
bang9
reviewed
May 31, 2024
packages/uikit-react-native-foundation/src/ui/GroupChannelMessage/MessageContainer.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native-foundation/src/ui/GroupChannelMessage/MessageContainer.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/components/GroupChannelMessageRenderer/index.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/components/ChannelInput/SendInput.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/localization/createBaseStringSet.ts
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
...react-native/src/domain/groupChannelThread/component/GroupChannelThreadParentMessageInfo.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
...react-native/src/domain/groupChannelThread/component/GroupChannelThreadParentMessageInfo.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
...kit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageReplyInfo.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/components/ChannelInput/index.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/components/ChannelMessageList/index.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/domain/groupChannelThread/module/moduleContext.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native/src/domain/groupChannelThread/module/moduleContext.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
May 31, 2024
packages/uikit-react-native-foundation/src/ui/GroupChannelMessage/MessageContainer.tsx
Outdated
Show resolved
Hide resolved
…feat/message-threading-qa
chore(CLNP-2919): fixed issues from message threading QA
@bang9 요것도 Approve 부탁드립니다~ |
bang9
reviewed
Jul 3, 2024
...kit-react-native/src/components/GroupChannelMessageRenderer/GroupChannelMessageReplyInfo.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 3, 2024
packages/uikit-react-native/src/components/ReactionAddons/MessageReactionAddon.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 3, 2024
packages/uikit-react-native/src/components/ReactionAddons/MessageReactionAddon.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 3, 2024
packages/uikit-react-native/src/containers/SendbirdUIKitContainer.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 3, 2024
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 3, 2024
packages/uikit-react-native/src/domain/groupChannel/module/moduleContext.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 8, 2024
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx
Outdated
Show resolved
Hide resolved
bang9
reviewed
Jul 8, 2024
packages/uikit-react-native/src/domain/groupChannel/component/GroupChannelMessageList.tsx
Outdated
Show resolved
Hide resolved
bang9
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!! 정말 고생많으셨습니다!
+혹시 다크모드 체크 하셨을까요?!
오우 아이렌도 정말 고생하셨습니다! 드디어 끝났네요 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
uikit-tools 패키지에 기능이 추가되어 uikit-core-ts 배포이후 package 버전 올려야 정상 동작합니다[CLNP-3087](https://sendbird.atlassian.net/browse/CLNP-3087)
Description Of Changes
Thread UI 추가
쓰레드 ParentMessage 종류별로 추가
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_