Skip to content

feat(CLNP-3087): message threading #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 82 commits into from
Jul 9, 2024
Merged

feat(CLNP-3087): message threading #181

merged 82 commits into from
Jul 9, 2024

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented May 30, 2024

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

uikit-tools 패키지에 기능이 추가되어 uikit-core-ts 배포이후 package 버전 올려야 정상 동작합니다
[CLNP-3087](https://sendbird.atlassian.net/browse/CLNP-3087)

Description Of Changes

  • 그룹채널 메세지 thread 관련 정보 추가(GroupChannelMessageReplyInfo.tsx)
Screenshot 2024-05-30 at 11 37 17 AM
  • Thread UI 추가

    • createGroupChannelThreadFragment.tsx
    • GroupChannelThreadScreen.tsx
    • groupChannelThread(Directory)
  • 쓰레드 ParentMessage 종류별로 추가

    • ThreadParentMessage.file.image.tsx
    • ThreadParentMessage.file.tsx
    • ThreadParentMessage.file.video.tsx
    • ThreadParentMessage.file.voice.tsx
    • ThreadParentMessage.user.og.tsx
    • ThreadParentMessage.user.tsx
Screenshot 2024-05-30 at 3 06 39 PM Screenshot 2024-05-30 at 3 08 18 PM Screenshot 2024-05-30 at 3 08 29 PM Screenshot 2024-05-30 at 3 04 42 PM Screenshot 2024-05-30 at 3 04 50 PM Screenshot 2024-05-30 at 3 05 19 PM Screenshot 2024-05-30 at 3 06 02 PM Screenshot 2024-05-30 at 3 07 08 PM Screenshot 2024-05-30 at 3 06 39 PM

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.45506% with 875 lines in your changes missing coverage. Please review.

Project coverage is 11.79%. Comparing base (3836c10) to head (5ef3876).

Files Patch % Lines
.../src/components/ChannelThreadMessageList/index.tsx 0.00% 115 Missing ⚠️
...src/fragments/createGroupChannelThreadFragment.tsx 0.00% 107 Missing ⚠️
.../component/GroupChannelThreadParentMessageInfo.tsx 0.00% 102 Missing ⚠️
...c/components/ThreadParentMessageRenderer/index.tsx 0.00% 85 Missing ⚠️
...Thread/component/GroupChannelThreadMessageList.tsx 0.00% 51 Missing and 1 partial ⚠️
...domain/groupChannelThread/module/moduleContext.tsx 0.00% 49 Missing ⚠️
...mponent/GroupChannelThreadSuggestedMentionList.tsx 0.00% 29 Missing ⚠️
...react-native/src/libs/VoiceMessageStatusManager.ts 0.00% 28 Missing ⚠️
...MessageRenderer/ThreadParentMessage.file.voice.tsx 0.00% 24 Missing ⚠️
...entMessageRenderer/ThreadParentMessage.user.og.tsx 0.00% 23 Missing ⚠️
... and 26 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
- Coverage   13.07%   11.79%   -1.28%     
==========================================
  Files         334      355      +21     
  Lines        7434     8266     +832     
  Branches     1919     2305     +386     
==========================================
+ Hits          972      975       +3     
- Misses       6461     7215     +754     
- Partials        1       76      +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OnestarLee OnestarLee force-pushed the feat/message-threading branch from d6b7734 to 1727b18 Compare May 30, 2024 06:53
@OnestarLee OnestarLee requested a review from bang9 May 30, 2024 07:16
@bang9 bang9 changed the title Feat(CLNP-3087): message threading feat(CLNP-3087): message threading May 31, 2024
@OnestarLee OnestarLee self-assigned this May 31, 2024
@OnestarLee OnestarLee requested a review from bang9 May 31, 2024 07:34
@OnestarLee
Copy link
Collaborator Author

@bang9 요것도 Approve 부탁드립니다~

@OnestarLee OnestarLee requested a review from bang9 July 3, 2024 04:37
Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 정말 고생많으셨습니다!

+혹시 다크모드 체크 하셨을까요?!

@OnestarLee
Copy link
Collaborator Author

오우 아이렌도 정말 고생하셨습니다! 드디어 끝났네요
다크모드 추가로 확인해봤고 이상없습니다!

@OnestarLee OnestarLee merged commit 5e815ea into main Jul 9, 2024
6 checks passed
@OnestarLee OnestarLee deleted the feat/message-threading branch July 9, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants