Skip to content

Commit 148b6dc

Browse files
authored
[CLNP-5111] feat: replace sdk.disconnect -> sdk.disconnectWebsocket (#1219)
Addresses https://sendbird.atlassian.net/browse/CLNP-5111 Changed the method we call when SendbirdProvider is unmounted from `disconnect()` to `disconnectWebsocket()` since `disconnect()` is equal to "logout" not just "disconnect".
1 parent 2e21451 commit 148b6dc

File tree

4 files changed

+6
-5
lines changed

4 files changed

+6
-5
lines changed

src/lib/Sendbird.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ const SendbirdSDK = ({
252252
sdk,
253253
});
254254
}
255-
}, [sdk.disconnect]);
255+
}, [sdk.disconnectWebSocket]);
256256

257257
// to create a pubsub to communicate between parent and child
258258
useEffect(() => {

src/lib/hooks/useConnect/__test__/data.mocks.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ export const mockSdk = {
2828
return Promise.reject();
2929
}),
3030
disconnect: jest.fn().mockImplementation(() => Promise.resolve(true)),
31+
disconnectWebSocket: jest.fn().mockImplementation(() => Promise.resolve(true)),
3132
updateCurrentUserInfo: jest.fn().mockImplementation((user) => Promise.resolve(user)),
3233
setSessionHandler: jest.fn(),
3334
addExtension: jest.fn(),

src/lib/hooks/useConnect/__test__/disconnectSdk.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ describe('useConnect/disconnectSdk', () => {
77
it('should call disconnectSdk when there is proper SDK', async () => {
88
// setup
99
const disconnectProps = generateDisconnectSdkParams();
10-
const mockDisconnect = disconnectProps.sdk.disconnect as jest.Mock;
10+
const mockDisconnect = disconnectProps.sdk.disconnectWebSocket as jest.Mock;
1111

1212
// execute
1313
await disconnectSdk(disconnectProps);
1414

1515
// verify
1616
expect(disconnectProps.sdkDispatcher).toHaveBeenCalledBefore(mockDisconnect);
1717
expect(disconnectProps.sdkDispatcher).toBeCalledWith({ type: SDK_ACTIONS.SET_SDK_LOADING, payload: true });
18-
expect(disconnectProps.sdk.disconnect).toHaveBeenCalled();
18+
expect(disconnectProps.sdk.disconnectWebSocket).toHaveBeenCalled();
1919
expect(disconnectProps.sdkDispatcher).toBeCalledWith({ type: SDK_ACTIONS.RESET_SDK });
2020
expect(disconnectProps.userDispatcher).toBeCalledWith({ type: USER_ACTIONS.RESET_USER });
2121
});

src/lib/hooks/useConnect/disconnectSdk.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ export async function disconnectSdk({
99
}: DisconnectSdkTypes): Promise<boolean> {
1010
return new Promise((resolve) => {
1111
sdkDispatcher({ type: SDK_ACTIONS.SET_SDK_LOADING, payload: true });
12-
if (sdk?.disconnect) {
13-
sdk.disconnect()
12+
if (sdk?.disconnectWebSocket) {
13+
sdk.disconnectWebSocket()
1414
.then(() => {
1515
sdkDispatcher({ type: SDK_ACTIONS.RESET_SDK });
1616
userDispatcher({ type: USER_ACTIONS.RESET_USER });

0 commit comments

Comments
 (0)