Skip to content

Commit 681205f

Browse files
authored
[CLNP-7450]Fixed a bug did not display read/deliver status icon in public groupChannel (#1365)
/ PR title (Required) [fix]: Fixed a bug that did not display the read/deliver status icon in the public groupChannel // PR description (Optional) - Message의 read/delivered status를 표시하는 조건이 public channel이 아닌 경우가 포함이 되어 있어서 이 부분 삭제를 했습니다. iOS/And의 경우에는 해당 조건이 없습니다. // Footer (Recommended) Fixes [CLNP-7450](https://sendbird.atlassian.net/browse/CLNP-7450) // Changelogs (Recommended) // Add (internal) at the end of each changelog if internal. ### Changelogs - Fixed a bug that did not display the read/deliver status icon in the public groupChannel ### Checklist Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members. This is a reminder of what we look for before merging your code. - [x] **All tests pass locally with my changes** - [ ] **I have added tests that prove my fix is effective or that my feature works** - [ ] **Public components / utils / props are appropriately exported** - [ ] I have added necessary documentation (if appropriate) ## External Contributions This project is not yet set up to accept pull requests from external contributors. If you have a pull request that you believe should be accepted, please contact the Developer Relations team <[email protected]> with details and we'll evaluate if we can set up a [CLA](https://en.wikipedia.org/wiki/Contributor_License_Agreement) to allow for the contribution. [CLNP-7450]: https://sendbird.atlassian.net/browse/CLNP-7450?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
1 parent 3874869 commit 681205f

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

src/modules/GroupChannel/context/hooks/useMessageActions.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,7 @@ export function useMessageActions(params: Params): MessageActions {
159159
});
160160
return message;
161161
},
162-
[buildInternalMessageParams, sendUserMessage, scrollToBottom, processParams],
162+
[buildInternalMessageParams, sendUserMessage, scrollToBottom, processParams, currentChannel?.url],
163163
),
164164
sendFileMessage: useCallback(
165165
async (params) => {
@@ -175,7 +175,7 @@ export function useMessageActions(params: Params): MessageActions {
175175

176176
return message;
177177
},
178-
[buildInternalMessageParams, sendFileMessage, scrollToBottom, processParams],
178+
[buildInternalMessageParams, sendFileMessage, scrollToBottom, processParams, currentChannel?.url],
179179
),
180180
sendMultipleFilesMessage: useCallback(
181181
async (params) => {
@@ -189,7 +189,7 @@ export function useMessageActions(params: Params): MessageActions {
189189
});
190190
return message;
191191
},
192-
[buildInternalMessageParams, sendMultipleFilesMessage, scrollToBottom, processParams],
192+
[buildInternalMessageParams, sendMultipleFilesMessage, scrollToBottom, processParams, currentChannel?.url],
193193
),
194194
sendVoiceMessage: useCallback(
195195
async (params: FileMessageCreateParams, duration: number) => {
@@ -211,7 +211,7 @@ export function useMessageActions(params: Params): MessageActions {
211211
const processedParams = await processParams(onBeforeSendVoiceMessage, internalParams, 'voice');
212212
return sendFileMessage(processedParams, asyncScrollToBottom);
213213
},
214-
[buildInternalMessageParams, sendFileMessage, scrollToBottom, processParams],
214+
[buildInternalMessageParams, sendFileMessage, scrollToBottom, processParams, currentChannel?.url],
215215
),
216216
updateUserMessage: useCallback(
217217
async (messageId: number, params: UserMessageUpdateParams) => {

src/ui/MessageStatus/index.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ export default function MessageStatus({
5050
const { stringSet, dateLocale } = useLocalization();
5151
const status = getOutgoingMessageState(channel, message);
5252
const hideMessageStatusIcon = channel?.isGroupChannel?.() && (
53-
(channel.isSuper || channel.isPublic || channel.isBroadcast)
53+
(channel.isSuper || channel.isBroadcast)
5454
&& !(status === OutgoingMessageStates.PENDING || status === OutgoingMessageStates.FAILED)
5555
);
5656

0 commit comments

Comments
 (0)