Skip to content

Commit e9e5076

Browse files
committed
[v3.2.1] (Oct 04 2022) (#325)
Fixes: * Donot bundle chat sdk with uikit compiled code Compiled UIKit code that is distributed through npm shouldnt have Chat SDK minified code included in it Chat SDK should be a dependency of UIKit Advantages: * Chat SDK bug fixes will be added for free * Eliminate the need for handlers What caused the issue: If you are usig rollup for bundling in config.external you have to be specific ie> This works: ``` external: [ '@sendbird/chat', '@sendbird/chat/groupChannel', '@sendbird/chat/openChannel', '@sendbird/chat/message', ] ``` This doesnt: ``` external: [ '@sendbird/chat', ] ``` * Only react and react-dom should be peerDependencies For npm >= v7, npm autoinstall peerDependency packages According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool
1 parent 16f7034 commit e9e5076

File tree

3 files changed

+41
-3
lines changed

3 files changed

+41
-3
lines changed

CHANGELOG.md

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,43 @@
11
# Changelog - v3
22

3+
## [v3.2.1] (Oct 02 2022)
4+
5+
Fixes:
6+
7+
* Do not bundle chat SDK with uikit compiled code
8+
9+
Compiled UIKit code that is distributed through npm shouldn't
10+
have Chat SDK minified code included in it
11+
Chat SDK should be a dependency of UIKit
12+
Advantages:
13+
* Chat SDK bug fixes will be added for free
14+
* Eliminate the need for handlers
15+
What caused the issue:
16+
If you are using rollup for bundling
17+
in config.external you have to be specific
18+
ie>
19+
This works:
20+
```
21+
external: [
22+
'@sendbird/chat',
23+
'@sendbird/chat/groupChannel',
24+
'@sendbird/chat/openChannel',
25+
'@sendbird/chat/message',
26+
]
27+
```
28+
This doesn't:
29+
```
30+
external: [ '@sendbird/chat', ]
31+
```
32+
33+
* Only react and react-dom should be peerDependencies
34+
35+
For npm >= v7, npm autoinstall peerDependency packages
36+
According to `https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies`
37+
You want to express the compatibility of your package with a host tool
38+
or library while not necessarily doing a require of this host Even though react is required,
39+
its better to show that react is the host tool
40+
341
## [v3.2.0] (Sep 27 2022)
442

543
Features:

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@sendbird/uikit-react",
3-
"version": "3.2.0",
3+
"version": "3.2.1",
44
"description": "React based UI kit for sendbird",
55
"main": "dist/index.js",
66
"style": "dist/index.css",

0 commit comments

Comments
 (0)