Skip to content

[CLNP-5418][fix]Fixed a bug MenuItem is over-placed when app area is narrow#1399

Merged
danney-chun merged 2 commits intomainfrom
bug-fix/CLNP-5418
Feb 6, 2026
Merged

[CLNP-5418][fix]Fixed a bug MenuItem is over-placed when app area is narrow#1399
danney-chun merged 2 commits intomainfrom
bug-fix/CLNP-5418

Conversation

@danney-chun
Copy link
Contributor

@danney-chun danney-chun commented Feb 4, 2026

// PR description

  • Fixed an issue where the ContextMenu kept its initially computed position and could move outside the layout when the browser was resized.

  • Added a resize event listener to recompute and update the ContextMenu position on window resize.

Fixes CLNP-5418

Changelogs

  • Fixed a bug MenuItem is over-place when app area is narrow

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.
This is a reminder of what we look for before merging your code.

  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • Public components / utils / props are appropriately exported
  • I have added necessary documentation (if appropriate)

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team developer-advocates@sendbird.com with details
and we'll evaluate if we can set up a CLA to allow for the contribution.

@danney-chun danney-chun self-assigned this Feb 4, 2026
@netlify
Copy link

netlify bot commented Feb 4, 2026

Deploy Preview for sendbird-uikit-react ready!

Name Link
🔨 Latest commit 6411765
🔍 Latest deploy log https://app.netlify.com/projects/sendbird-uikit-react/deploys/69842dab7db42500084babb8
😎 Deploy Preview https://deploy-preview-1399--sendbird-uikit-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

return null;
}

useEffect(() => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useEffect 가 if (user.userId === currentUserId) 조건문 처리 상단에 와야될것 같습니다

https://react.dev/reference/rules/rules-of-hooks

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

흠 요런 규칙이 있었군요. 반영 했습니다.

Copy link
Contributor

@OnestarLee OnestarLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@danney-chun danney-chun merged commit d70db90 into main Feb 6, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants