Skip to content

Commit 680bfca

Browse files
authored
[express] Add null check for Sentry span before setting attributes (#1279)
Co-authored-by: sentry[bot] <39604003+sentry[bot]@users.noreply.github.com>
1 parent 4421348 commit 680bfca

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

express/db.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,14 +56,15 @@ const getJoinedProducts = async function () {
5656
});
5757

5858
Sentry.setTag("totalProducts", products.rows.length);
59-
span.setAttribute("Products", products.rows);
59+
const span = Sentry.getActiveSpan();
60+
if (span) span.setAttribute("Products", products.rows);
6061

6162
// Retrieve Reviews
6263
const reviewsQuery =
6364
"SELECT reviews.id, products.id AS productid, reviews.rating, reviews.customerId, reviews.description, reviews.created FROM reviews INNER JOIN products ON reviews.productId = products.id";
6465

6566
const retrievedReviews = await knex.raw(reviewsQuery);
66-
span.setAttribute("reviews", retrievedReviews.rows);
67+
if (span) span.setAttribute("reviews", retrievedReviews.rows);
6768

6869
// Format Products/Reviews
6970

@@ -74,7 +75,7 @@ const getJoinedProducts = async function () {
7475
formattedProducts.push(productWithReviews);
7576
}
7677

77-
span.setAttribute("results", formattedProducts);
78+
if (span) span.setAttribute("results", formattedProducts);
7879

7980
return formattedProducts;
8081
};

0 commit comments

Comments
 (0)