[Minor issue] Unused Argument "memories" in EntanglementSwappingA.set_others()

[caitaozhan]

Hi SeQUeNCe team,

I have been playing around with SeQUeNCe recently and found a minor issue, located at this link:
https://github.com/sequence-toolbox/SeQUeNCe/blob/b7cc48da8ec00106cc68aa11ecf5e09c9e54d768/src/entanglement_management/swapping.py#L129C52-L129C60

The function EntanglementSwappingA.set_others() has an argument memories, but it is not used inside the function. This is also the case in EntanglementSwappingB.set_others()

Thanks,
Caitao

[anshsingal]

Thanks a lot for pointing that out! I'll create a new branch with the updated definition and corrections in all corresponding function calls.

[caitaozhan]

Thanks for the response.

[rayair250-droid]

The memories parameter is part of the shared EntanglementProtocol.set_others(remote_protocol, remote_node, memories) interface (entanglement_protocol.py) and is invoked positionally from ResourceManager (resource_manager.py:410 and :439) on any protocol instance. EntanglementGenerationA/B.set_others do use it (self.remote_memo_id = memories[0]), so it cannot simply be dropped from the swapping override: the positional calls require every implementation to keep the same three arguments, and removing it would raise a TypeError when the manager pairs a swapping protocol.

Worth noting the same unused-memories case also applies to EntanglementSwappingB.set_others, not only EntanglementSwappingA — both key off the left_memo/right_memo they already hold rather than the passed memories list.

An interface-preserving resolution would be to keep the parameter and document that it is intentionally unused in the swapping protocols. Happy to open a small PR for that if it sounds reasonable.