chore: rand::thread_rng renamed to rand::rng #70
zonyitoo
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
30 warnings
|
buid-test-check (ubuntu-latest)
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
buid-test-check (windows-latest)
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
large size difference between variants:
src/v2/udp/mod.rs#L14
warning: large size difference between variants
--> src/v2/udp/mod.rs:14:1
|
14 | / enum CipherVariant {
15 | | AesGcm(AesGcmCipher),
| | -------------------- the largest variant contains at least 560 bytes
16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher),
| | ---------------------------------------- the second-largest variant contains at least 32 bytes
17 | | #[cfg(feature = "v2-extra")]
18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher),
19 | | }
| |_^ the entire enum is at least 560 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
15 - AesGcm(AesGcmCipher),
15 + AesGcm(Box<AesGcmCipher>),
|
|
|
the borrowed expression implements the required traits:
src/v1/cipher.rs#L24
warning: the borrowed expression implements the required traits
--> src/v1/cipher.rs:24:22
|
24 | m.update(&digest);
| ^^^^^^^ help: change this to: `digest`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
the loop variable `i` is used to index `table`:
src/v1/streamcipher/table.rs#L27
warning: the loop variable `i` is used to index `table`
--> src/v1/streamcipher/table.rs:27:18
|
27 | for i in 0..table.len() {
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
27 - for i in 0..table.len() {
27 + for (i, <item>) in table.iter_mut().enumerate() {
|
|
|
manually filling a slice:
src/v1/streamcipher/table.rs#L27
warning: manually filling a slice
--> src/v1/streamcipher/table.rs:27:9
|
27 | / for i in 0..table.len() {
28 | | table[i] = i as u64;
29 | | }
| |_________^ help: try: `table.fill(i as u64);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_fill
= note: `#[warn(clippy::manual_slice_fill)]` on by default
|
|
the loop variable `counter` is only used to index `data`:
src/v1/streamcipher/crypto/rc4.rs#L66
warning: the loop variable `counter` is only used to index `data`
--> src/v1/streamcipher/crypto/rc4.rs:66:24
|
66 | for counter in 0..data.len() {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
66 - for counter in 0..data.len() {
66 + for <item> in &mut data {
|
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/v1/streamcipher/crypto/rc4.rs#L53
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/v1/streamcipher/crypto/rc4.rs:53:24
|
53 | state.swap(counter as usize, index2 as usize);
| ^^^^^^^^^^^^^^^^ help: try: `counter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
constants have by default a `'static` lifetime:
src/v1/cipher.rs#L92
warning: constants have by default a `'static` lifetime
--> src/v1/cipher.rs:92:37
|
92 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey";
| -^^^^^^^----- help: consider removing `'static`: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (ubuntu-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (windows-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (macos-latest)
Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down
|
|
large size difference between variants:
src/v2/udp/mod.rs#L14
warning: large size difference between variants
--> src/v2/udp/mod.rs:14:1
|
14 | / enum CipherVariant {
15 | | AesGcm(AesGcmCipher),
| | -------------------- the largest variant contains at least 560 bytes
16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher),
| | ---------------------------------------- the second-largest variant contains at least 32 bytes
17 | | #[cfg(feature = "v2-extra")]
18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher),
19 | | }
| |_^ the entire enum is at least 560 bytes
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant
= note: `#[warn(clippy::large_enum_variant)]` on by default
help: consider boxing the large fields to reduce the total size of the enum
|
15 - AesGcm(AesGcmCipher),
15 + AesGcm(Box<AesGcmCipher>),
|
|
|
the borrowed expression implements the required traits:
src/v1/cipher.rs#L24
warning: the borrowed expression implements the required traits
--> src/v1/cipher.rs:24:22
|
24 | m.update(&digest);
| ^^^^^^^ help: change this to: `digest`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
|
|
consider using `sort_by_key`:
src/v1/streamcipher/table.rs#L32
warning: consider using `sort_by_key`
--> src/v1/streamcipher/table.rs:32:13
|
32 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i))))
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by
= note: `#[warn(clippy::unnecessary_sort_by)]` on by default
|
|
the loop variable `i` is used to index `table`:
src/v1/streamcipher/table.rs#L27
warning: the loop variable `i` is used to index `table`
--> src/v1/streamcipher/table.rs:27:18
|
27 | for i in 0..table.len() {
| ^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
help: consider using an iterator and enumerate()
|
27 - for i in 0..table.len() {
27 + for (i, <item>) in table.iter_mut().enumerate() {
|
|
|
manually filling a slice:
src/v1/streamcipher/table.rs#L27
warning: manually filling a slice
--> src/v1/streamcipher/table.rs:27:9
|
27 | / for i in 0..table.len() {
28 | | table[i] = i as u64;
29 | | }
| |_________^ help: try: `table.fill(i as u64);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_slice_fill
= note: `#[warn(clippy::manual_slice_fill)]` on by default
|
|
the loop variable `counter` is only used to index `data`:
src/v1/streamcipher/crypto/rc4.rs#L66
warning: the loop variable `counter` is only used to index `data`
--> src/v1/streamcipher/crypto/rc4.rs:66:24
|
66 | for counter in 0..data.len() {
| ^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
= note: `#[warn(clippy::needless_range_loop)]` on by default
help: consider using an iterator
|
66 - for counter in 0..data.len() {
66 + for <item> in &mut data {
|
|
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/v1/streamcipher/crypto/rc4.rs#L53
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/v1/streamcipher/crypto/rc4.rs:53:24
|
53 | state.swap(counter as usize, index2 as usize);
| ^^^^^^^^^^^^^^^^ help: try: `counter`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
|
constants have by default a `'static` lifetime:
src/v1/cipher.rs#L92
warning: constants have by default a `'static` lifetime
--> src/v1/cipher.rs:92:37
|
92 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey";
| -^^^^^^^----- help: consider removing `'static`: `&[u8]`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
= note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
|
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|
|
buid-test-check (macos-latest)
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
|