warning: hiding a lifetime that's elided elsewhere is confusing --> src/v1/aeadcipher/sm4_gcm_cipher.rs:131:17 | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE, Block) { | ^^^^^ ^^^^^^^ the same lifetime is hidden here | | | the lifetime is elided here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE<'_>, Block) { | ++++

warning: large size difference between variants --> src/v2/udp/mod.rs:14:1 | 14 | / enum CipherVariant { 15 | | AesGcm(AesGcmCipher), | | -------------------- the largest variant contains at least 560 bytes 16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher), | | ---------------------------------------- the second-largest variant contains at least 32 bytes 17 | | #[cfg(feature = "v2-extra")] 18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher), 19 | | } | |_^ the entire enum is at least 560 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum | 15 - AesGcm(AesGcmCipher), 15 + AesGcm(Box<AesGcmCipher>), |

warning: the borrowed expression implements the required traits --> src/v1/cipher.rs:24:22 | 24 | m.update(&digest); | ^^^^^^^ help: change this to: `digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: consider using `sort_by_key` --> src/v1/streamcipher/table.rs:32:13 | 32 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i)))) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_sort_by = note: `#[warn(clippy::unnecessary_sort_by)]` on by default

warning: the loop variable `i` is used to index `table` --> src/v1/streamcipher/table.rs:27:18 | 27 | for i in 0..table.len() { | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop help: consider using an iterator and enumerate() | 27 - for i in 0..table.len() { 27 + for (i, <item>) in table.iter_mut().enumerate() { |

warning: the loop variable `counter` is only used to index `data` --> src/v1/streamcipher/crypto/rc4.rs:66:24 | 66 | for counter in 0..data.len() { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 66 - for counter in 0..data.len() { 66 + for <item> in &mut data { |

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/v1/streamcipher/crypto/rc4.rs:53:24 | 53 | state.swap(counter as usize, index2 as usize); | ^^^^^^^^^^^^^^^^ help: try: `counter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: constants have by default a `'static` lifetime --> src/v1/cipher.rs:92:37 | 92 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey"; | -^^^^^^^----- help: consider removing `'static`: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default

warning: hiding a lifetime that's elided elsewhere is confusing --> src/v1/aeadcipher/sm4_gcm_cipher.rs:131:17 | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE, Block) { | ^^^^^ ^^^^^^^ the same lifetime is hidden here | | | the lifetime is elided here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE<'_>, Block) { | ++++

warning: large size difference between variants --> src/v2/udp/mod.rs:14:1 | 14 | / enum CipherVariant { 15 | | AesGcm(AesGcmCipher), | | -------------------- the largest variant contains at least 560 bytes 16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher), | | ---------------------------------------- the second-largest variant contains at least 32 bytes 17 | | #[cfg(feature = "v2-extra")] 18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher), 19 | | } | |_^ the entire enum is at least 560 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum | 15 - AesGcm(AesGcmCipher), 15 + AesGcm(Box<AesGcmCipher>), |

warning: the borrowed expression implements the required traits --> src/v1/cipher.rs:24:22 | 24 | m.update(&digest); | ^^^^^^^ help: change this to: `digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: consider using `sort_by_key` --> src/v1/streamcipher/table.rs:32:13 | 32 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i)))) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_sort_by = note: `#[warn(clippy::unnecessary_sort_by)]` on by default

warning: the loop variable `i` is used to index `table` --> src/v1/streamcipher/table.rs:27:18 | 27 | for i in 0..table.len() { | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop help: consider using an iterator and enumerate() | 27 - for i in 0..table.len() { 27 + for (i, <item>) in table.iter_mut().enumerate() { |

warning: the loop variable `counter` is only used to index `data` --> src/v1/streamcipher/crypto/rc4.rs:66:24 | 66 | for counter in 0..data.len() { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 66 - for counter in 0..data.len() { 66 + for <item> in &mut data { |

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/v1/streamcipher/crypto/rc4.rs:53:24 | 53 | state.swap(counter as usize, index2 as usize); | ^^^^^^^^^^^^^^^^ help: try: `counter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: constants have by default a `'static` lifetime --> src/v1/cipher.rs:92:37 | 92 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey"; | -^^^^^^^----- help: consider removing `'static`: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default

warning: hiding a lifetime that's elided elsewhere is confusing --> src/v1/aeadcipher/sm4_gcm_cipher.rs:131:17 | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE, Block) { | ^^^^^ ^^^^^^^ the same lifetime is hidden here | | | the lifetime is elided here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE<'_>, Block) { | ++++

warning: large size difference between variants --> src/v2/udp/mod.rs:14:1 | 14 | / enum CipherVariant { 15 | | AesGcm(AesGcmCipher), | | -------------------- the largest variant contains at least 560 bytes 16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher), | | ---------------------------------------- the second-largest variant contains at least 32 bytes 17 | | #[cfg(feature = "v2-extra")] 18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher), 19 | | } | |_^ the entire enum is at least 560 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum | 15 - AesGcm(AesGcmCipher), 15 + AesGcm(Box<AesGcmCipher>), |

warning: the borrowed expression implements the required traits --> src/v1/cipher.rs:24:22 | 24 | m.update(&digest); | ^^^^^^^ help: change this to: `digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: consider using `sort_by_key` --> src/v1/streamcipher/table.rs:32:13 | 32 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i)))) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_sort_by = note: `#[warn(clippy::unnecessary_sort_by)]` on by default

warning: the loop variable `i` is used to index `table` --> src/v1/streamcipher/table.rs:27:18 | 27 | for i in 0..table.len() { | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop help: consider using an iterator and enumerate() | 27 - for i in 0..table.len() { 27 + for (i, <item>) in table.iter_mut().enumerate() { |

warning: the loop variable `counter` is only used to index `data` --> src/v1/streamcipher/crypto/rc4.rs:66:24 | 66 | for counter in 0..data.len() { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 66 - for counter in 0..data.len() { 66 + for <item> in &mut data { |

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/v1/streamcipher/crypto/rc4.rs:53:24 | 53 | state.swap(counter as usize, index2 as usize); | ^^^^^^^^^^^^^^^^ help: try: `counter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default

warning: constants have by default a `'static` lifetime --> src/v1/cipher.rs:92:37 | 92 | const SUBKEY_INFO: &'static [u8] = b"ss-subkey"; | -^^^^^^^----- help: consider removing `'static`: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#redundant_static_lifetimes = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default

warning: hiding a lifetime that's elided elsewhere is confusing --> src/v1/aeadcipher/sm4_gcm_cipher.rs:131:17 | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE, Block) { | ^^^^^ ^^^^^^^ the same lifetime is hidden here | | | the lifetime is elided here | = help: the same lifetime is referred to in inconsistent ways, making the signature confusing = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default help: use `'_` for type paths | 131 | fn init_ctr(&self, nonce: &Nonce) -> (Ctr32BE<'_>, Block) { | ++++

warning: large size difference between variants --> src/v2/udp/mod.rs:14:1 | 14 | / enum CipherVariant { 15 | | AesGcm(AesGcmCipher), | | -------------------- the largest variant contains at least 560 bytes 16 | | ChaCha20Poly1305(ChaCha20Poly1305Cipher), | | ---------------------------------------- the second-largest variant contains at least 32 bytes 17 | | #[cfg(feature = "v2-extra")] 18 | | ChaCha8Poly1305(ChaCha8Poly1305Cipher), 19 | | } | |_^ the entire enum is at least 560 bytes | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#large_enum_variant = note: `#[warn(clippy::large_enum_variant)]` on by default help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum | 15 - AesGcm(AesGcmCipher), 15 + AesGcm(Box<AesGcmCipher>), |

warning: the borrowed expression implements the required traits --> src/v1/cipher.rs:24:22 | 24 | m.update(&digest); | ^^^^^^^ help: change this to: `digest` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

warning: consider using `sort_by_key` --> src/v1/streamcipher/table.rs:32:13 | 32 | table.sort_by(|x, y| (a % (*x + i)).cmp(&(a % (*y + i)))) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `table.sort_by_key(|x| a % (*x + i))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_sort_by = note: `#[warn(clippy::unnecessary_sort_by)]` on by default

warning: the loop variable `i` is used to index `table` --> src/v1/streamcipher/table.rs:27:18 | 27 | for i in 0..table.len() { | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop help: consider using an iterator and enumerate() | 27 - for i in 0..table.len() { 27 + for (i, <item>) in table.iter_mut().enumerate() { |

warning: the loop variable `counter` is only used to index `data` --> src/v1/streamcipher/crypto/rc4.rs:66:24 | 66 | for counter in 0..data.len() { | ^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#needless_range_loop = note: `#[warn(clippy::needless_range_loop)]` on by default help: consider using an iterator | 66 - for counter in 0..data.len() { 66 + for <item> in &mut data { |

warning: casting to the same type is unnecessary (`usize` -> `usize`) --> src/v1/streamcipher/crypto/rc4.rs:53:24 | 53 | state.swap(counter as usize, index2 as usize); | ^^^^^^^^^^^^^^^^ help: try: `counter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.91.0/index.html#unnecessary_cast = note: `#[warn(clippy::unnecessary_cast)]` on by default