Skip to content

Commit d5295d3

Browse files
committed
fix: clarify demos seam validation contract
1 parent 46aecff commit d5295d3

4 files changed

Lines changed: 25 additions & 5 deletions

File tree

.agents/agent-workflow.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
---
22
base_branch: main
33
follow_up_prefix: 'Follow-up:'
4-
review_gate: "all current-head `gh pr checks` entries green, all review threads resolved, mergeable clean; AGENTS.md permits `gh pr ready` only after its documented local and review-app conditions pass"
4+
review_gate: "all current-head `gh pr checks` entries green, all review threads resolved, mergeable clean; local seam evidence is `.agents/bin/validate` (`bundle exec rake spec`) only, not a replacement for Lefthook pre-push or monorepo lint/format; AGENTS.md permits `gh pr ready` only after its documented local and review-app conditions pass"
55
approval_exempt: "this config grants no permanent merge authority; defer merge authority to AGENTS.md or direct user/maintainer instruction. When separately authorized at batch closeout, auto-merge ready low-risk PRs that pass the merge gate; keep high-risk CI/workflow, build-config, dependency or runtime bumps, broad refactors, and release changes maintainer-gated"
66
coordination_backend: n/a
77
changelog: n/a

.agents/bin/README.md

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,19 @@ installs tools nor runs `mise trust` automatically.
1515
| Script | Purpose | This repo runs |
1616
| --- | --- | --- |
1717
| `setup` | Install Ruby and Node dependencies, then attempt git hooks | `bin/conductor-exec bundle install "$@"`; `bin/conductor-exec npm install`; best-effort `bin/conductor-exec bundle exec lefthook install` |
18-
| `validate` | Pre-push gate | `bin/conductor-exec bundle exec rake spec` |
19-
| `test` | Run tests | `bin/conductor-exec bundle exec rspec "$@"` |
20-
| `lint` | Lint / format | n/a |
18+
| `validate` | Run the root RSpec task | `bin/conductor-exec bundle exec rake spec` (no arguments) |
19+
| `test` | Run the root RSpec task | `bin/conductor-exec bundle exec rake spec` (no arguments) |
20+
| `lint` | Lint / format | n/a — this seam deliberately does not wrap the monorepo-wide RuboCop command |
2121
| `build` | Build / type-check | n/a |
2222
| `docs` | Docs checks | n/a |
2323
| `ci-detect` | CI change detector | n/a |
2424

2525
Non-command policy lives in [`../agent-workflow.yml`](../agent-workflow.yml).
26+
27+
## Validation scope
28+
29+
`validate` and `test` intentionally run only the repository root RSpec task.
30+
They are useful local seam checks, but are not a replacement for the
31+
repository's Lefthook pre-push checks or monorepo-wide lint and format commands.
32+
Use the repository documentation for those broader checks. Both scripts reject
33+
arguments so their documented contract stays deterministic.

.agents/bin/test

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,10 @@
22
# Generated by shakacode/agent-workflows agent-workflow-seam-doctor --init.
33
set -euo pipefail
44
cd "$(CDPATH= cd -- "$(dirname -- "$0")/../.." && pwd)"
5-
exec bin/conductor-exec bundle exec rspec "$@"
5+
6+
if (( $# > 0 )); then
7+
printf '%s\n' 'error: .agents/bin/test runs the repository root `rake spec` task and accepts no arguments' >&2
8+
exit 64
9+
fi
10+
11+
exec bin/conductor-exec bundle exec rake spec

.agents/bin/validate

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,10 @@
22
# Generated by shakacode/agent-workflows agent-workflow-seam-doctor --init.
33
set -euo pipefail
44
cd "$(CDPATH= cd -- "$(dirname -- "$0")/../.." && pwd)"
5+
6+
if (( $# > 0 )); then
7+
printf '%s\n' 'error: .agents/bin/validate runs the repository root `rake spec` task and accepts no arguments' >&2
8+
exit 64
9+
fi
10+
511
exec bin/conductor-exec bundle exec rake spec

0 commit comments

Comments
 (0)