Skip to content

Add agent workflows seam - #125

Merged
justin808 merged 7 commits into
mainfrom
codex/seam-20260711-react-on-rails-demos
Jul 15, 2026
Merged

Add agent workflows seam#125
justin808 merged 7 commits into
mainfrom
codex/seam-20260711-react-on-rails-demos

Conversation

@justin808

Copy link
Copy Markdown
Member

Summary

  • add the repository-owned agent-workflow seam, wrappers, policy, trust configuration, and AGENTS.md pointer

Validation

  • agent-workflow-seam-doctor --root . --shared /Users/justin/src/agent-workflows
  • bash -n .agents/bin/{validate,test}
  • git diff --check

Validation gap

  • The isolated sparse worktree excludes spec/ and lib/, so the existing RSpec suite cannot load spec_helper; root RuboCop also has pre-existing offenses. The seam itself is validated and hosted CI should run the full existing contract.

Copilot AI review requested due to automatic review settings July 12, 2026 03:53
@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@justin808, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 55db6e4b-59c4-4285-a290-b237eee4ddb0

📥 Commits

Reviewing files that changed from the base of the PR and between bd55456 and d5295d3.

📒 Files selected for processing (7)
  • .agents/agent-workflow.yml
  • .agents/bin/README.md
  • .agents/bin/setup
  • .agents/bin/test
  • .agents/bin/validate
  • .agents/trusted-github-actors.yml
  • AGENTS.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/seam-20260711-react-on-rails-demos

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds the repository-owned “agent-workflow seam” so portable agent-workflow skills can discover repo-specific commands and policy via a standard .agents/ layout.

Changes:

  • Introduces .agents/agent-workflow.yml plus trust configuration (.agents/trusted-github-actors.yml).
  • Adds standard agent command entrypoints (.agents/bin/validate, .agents/bin/test) and documents them in .agents/bin/README.md.
  • Updates AGENTS.md to point contributors/agents at the new command and policy locations.

Reviewed changes

Copilot reviewed 3 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
AGENTS.md Documents where agent workflows resolve repo commands and policy.
.agents/trusted-github-actors.yml Adds trust allowlist configuration scaffold (currently empty lists).
.agents/bin/validate Adds agent “validate” entrypoint (currently defaults to rake default task).
.agents/bin/test Adds agent “test” entrypoint (bundle exec rspec).
.agents/bin/README.md Documents standard .agents/bin/* scripts and their behavior.
.agents/agent-workflow.yml Adds baseline agent-workflow policy/config keys for the repo.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .agents/bin/validate Outdated
Comment thread .agents/bin/README.md Outdated
@claude

claude Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review: Add agent workflows seam

Overview

Adds the repository-owned "agent workflow seam" generated by shakacode/agent-workflows agent-workflow-seam-doctor --init: a policy file (.agents/agent-workflow.yml), two entry-point scripts (.agents/bin/{validate,test}), a README documenting the seam's contract, an empty trust list (.agents/trusted-github-actors.yml), and a pointer section appended to AGENTS.md. No application code changes — root Gemfile/Rakefile already back the validate/test commands (bundle exec rake and bundle exec rspec), so the wrappers resolve correctly against demos/'s parent repo root.

Code quality

  • The cd idiom in both scripts (cd "$(CDPATH= cd -- "$(dirname -- "$0")/../.." && pwd)") is a defensively-written, portable way to resolve the repo root regardless of caller cwd — good practice, guards against CDPATH surprises and paths starting with -.
  • set -euo pipefail + exec ... "$@" in both scripts is correct (fail-fast, forwards argv, replaces the shell process rather than spawning a subshell).
  • Scripts are executable (755) as required for direct invocation.
  • Content is machine-generated boilerplate from an external tool; low surface area for bugs.

Risk / follow-up worth tracking

  • The PR description itself flags a validation gap: root RuboCop has pre-existing offenses, and .agents/bin/validate runs bundle exec rake, whose default task is spec + rubocop. That means any agent that shells out to .agents/bin/validate as its pre-push/pre-merge gate will see a failing gate today, independent of whatever change it's validating — worth a fast follow-up to either fix the existing RuboCop offenses or scope validate to just the newly-touched files until that's done, so the gate isn't red by default for unrelated agent work.
  • lint is marked n/a in both .agents/bin/README.md and (implicitly) not wired up, even though the repo already has .rubocop.yml and a format:check npm script (Prettier) at the root. Since RuboCop is already folded into validate, this is a minor completeness gap rather than a bug — could optionally wire .agents/bin/lint to npm run format:check (and/or bundle exec rubocop standalone) later so lint/format checks are independently runnable without the full test suite.

Security

  • .agents/trusted-github-actors.yml ships with all trust lists empty (trusted_users: [], trusted_bots: [], etc.) — a safe, restrictive-by-default posture.

No blocking issues found; this is low-risk, additive tooling config.

Comment thread .agents/bin/validate Outdated
Comment thread .agents/bin/README.md Outdated
@greptile-apps

greptile-apps Bot commented Jul 12, 2026

Copy link
Copy Markdown

Greptile Summary

This PR adds the repository-owned agent workflow seam. The main changes are:

  • New .agents/agent-workflow.yml policy/config file.
  • New .agents/bin/test and .agents/bin/validate wrappers.
  • New trusted GitHub actor configuration.
  • Updated AGENTS.md pointer for shared skills.

Confidence Score: 4/5

The workflow seam needs clearer policy defaults before shared skills rely on it.

  • The command wrappers match the repo’s root test and validation commands.
  • The new policy file can hide the existing PR-ready gate from shared skills.
  • The trusted-actor file leaves empty-list behavior undefined for approval and metadata actions.

.agents/agent-workflow.yml and .agents/trusted-github-actors.yml

Security Review

The new workflow and trusted-actor config files define a security-sensitive policy boundary, but the review gate and trust defaults are ambiguous. Shared skills can misapply PR readiness, approval, or trusted-actor behavior until those defaults are explicit.

Important Files Changed

Filename Overview
.agents/agent-workflow.yml Adds workflow policy keys, but the review and approval controls are set to n/a while AGENTS.md points shared skills at this file.
.agents/trusted-github-actors.yml Adds trusted-actor allowlists, but all lists are empty with no explicit default-deny behavior.
.agents/bin/test Adds a root-level RSpec wrapper that forwards arguments safely.
.agents/bin/validate Adds a root-level rake wrapper for validation.
.agents/bin/README.md Documents the generated agent workflow command wrappers.
AGENTS.md Adds the pointer from shared skills to the new .agents command and policy files.

Reviews (1): Last reviewed commit: "chore: add agent workflows seam" | Re-trigger Greptile

Comment thread .agents/agent-workflow.yml Outdated
Comment thread .agents/trusted-github-actors.yml

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6605258bbf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/bin/README.md Outdated
Comment thread .agents/bin/validate Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 02:48
Comment thread .agents/bin/setup Outdated
Comment thread .agents/bin/validate Outdated
@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review: Add agent workflows seam

Overview

Adds the repository-owned "seam" that portable shakacode/agent-workflows skills use to discover this repo's commands and policy: .agents/agent-workflow.yml (policy, mostly n/a), .agents/bin/{setup,test,validate} wrappers, .agents/bin/README.md, .agents/trusted-github-actors.yml (empty trust lists), and an AGENTS.md pointer section. Pure scaffolding/config — no application code touched.

Code quality

  • The three wrapper scripts (setup, test, validate) are small, use set -euo pipefail, and correctly resolve the repo root regardless of CWD (cd "$(CDPATH= cd -- "$(dirname -- "$0")/../.." && pwd)"). Good, defensive shell.
  • Consistent, sensible use of bin/conductor-exec for all Ruby invocations, matching the pattern this repo's CLAUDE.md already documents — and safe even outside Conductor since conductor-exec falls back to direct execution when mise isn't present.
  • trusted-github-actors.yml defaults to empty lists everywhere, i.e. fails closed (nothing trusted by default) — good security default for a new file whose consumers aren't in this diff.
  • Minor style nit: .agents/bin/setup doesn't carry the <!-- Generated by ... --init -->-style comment that test and validate have; harmless, just an inconsistency if these are meant to be regenerated by the seam-doctor tool later.

Issues found (posted inline)

  1. .agents/bin/setup under-provisions vs. the repo's existing conductor-setup.sh. It only runs bundle install. The existing setup script also runs npm install and, importantly, bundle exec lefthook install — the latter installs the git pre-push hook that CLAUDE.md relies on to prevent local bin/swap-deps gem paths from being pushed. An agent bootstrapping only through this new seam won't get that safety net.
  2. .agents/bin/validate (documented as the "Pre-push gate") omits RuboCop, even though the repo's own Rakefile default task is spec + rubocop, and conductor-setup.sh explicitly warns "Always run bundle exec rubocop before committing!". The PR description discloses this gap ("pre-existing RuboCop offenses") but that context isn't captured in the committed files themselves. Since AGENTS.md in this same PR pre-authorizes Codex to auto-mark PRs ready once checks pass, a weakened validate gate has real downstream effect.

Lower-confidence observation (not filed inline)

  • .agents/bin/test only exercises the root spec/ suite (the demo_scripts lib tooling), not packages/demo_common or demos/*, which the repo's existing bin/test-all covers. This may be intentional given CI already gates those separately, but worth confirming it's not assumed to be "run all the tests" by future agents.

Security

No secrets or credentials introduced. Empty trust lists are a safe default. No injection/XSS/etc. surface — these are local dev-tooling scripts only.

Test coverage

N/A for this change type; PR description notes bash -n syntax checks and manual agent-workflow-seam-doctor validation were run, which is reasonable for scaffolding files.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated 2 comments.

Comment thread .agents/bin/validate Outdated
Comment thread .agents/bin/README.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7604cd49be

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/bin/setup Outdated
Copilot AI review requested due to automatic review settings July 15, 2026 03:24

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.

Comment thread .agents/bin/test Outdated
Comment thread .agents/bin/setup Outdated
Comment thread .agents/bin/test Outdated
Comment thread .agents/bin/validate Outdated
@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review: Add agent workflows seam

Overview

This PR adds a repository-owned "seam" for the shared agent-workflows tooling: .agents/agent-workflow.yml (policy config), .agents/bin/{setup,validate,test} wrappers, .agents/trusted-github-actors.yml (empty/deny-by-default trust config), a README.md documenting the contract, and a pointer section appended to AGENTS.md. It's purely additive — no existing config (Shakapacker/webpack/React on Rails settings) is touched, which matches this repo's upgrade guidelines.

Main finding: setup/test/validate only cover the root tooling library, not the actual demos or shared package

This repo is a monorepo: the product code lives in packages/shakacode_demo_common and demos/*, each with its own Gemfile/package.json. The root Gemfile/Rakefile/package.json only exist for the lib/demo_scripts tooling (the bin/* management scripts) plus prettier.

The new scripts operate entirely at the root:

  • .agents/bin/setupbundle install + npm install at root — never installs deps for shakacode_demo_common or any demo.
  • .agents/bin/testbundle exec rspec at root — only runs spec/demo_scripts/*, never packages/shakacode_demo_common/spec or any demo's specs.
  • .agents/bin/validatebundle exec rake spec at root — same gap, and also doesn't match the actual pre-push lefthook hook (which only runs the local-gem-path check, not specs/rubocop).

The repo already has comprehensive equivalents for this: bin/bootstrap-all (installs deps across shakacode_demo_common + every demo) and bin/test-all (runs RSpec/RuboCop/JS tests across the same). CI (.github/workflows/ci.yml) also tests inside packages/demo_common and per-demo, not at repo root. As written, an agent that runs .agents/bin/setup && .agents/bin/test and sees success would have a false sense that the demo apps/shared package are installed and passing — they were never touched. Left inline comments with suggested fixes (delegate to bin/bootstrap-all / bin/test-all).

Other notes

  • .agents/bin/README.md's claim that setup will "Install Ruby and Node dependencies" and validate is the "Pre-push gate" is optimistic given the above — worth tightening once the scripts are fixed.
  • .agents/trusted-github-actors.yml defaults to empty trust lists (deny-by-default) — reasonable, no concerns.
  • .agents/agent-workflow.yml's n/a markers for unused policy keys (review_gate, coordination_backend, etc.) look consistent with the generator's stated convention ("a script/field that's absent means that capability is n/a").
  • The AGENTS.md addition is a small, non-destructive append — fine.
  • No security concerns: the new scripts just pass "$@" through to bundle/npm/lefthook via the existing bin/conductor-exec wrapper, no injection surface.

Test coverage

No tests are added/needed for shell wrapper scripts, but per the PR's own "Validation gap" note, the seam itself wasn't validated against a full checkout (sparse worktree excluded spec//lib/) — worth a manual run of .agents/bin/{setup,validate,test} against a full checkout before merge, especially after addressing the scope gap above.

Copilot AI review requested due to automatic review settings July 15, 2026 03:44
Comment thread .agents/agent-workflow.yml Outdated
Comment thread .agents/bin/validate Outdated
Comment thread .agents/bin/test Outdated
@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review: Add agent workflows seam

Overview

Adds the repository-owned "agent-workflow seam" that portable shakacode/agent-workflows shared skills use to discover this repo's commands/policy: .agents/agent-workflow.yml, .agents/bin/{setup,validate,test} wrappers + README, .agents/trusted-github-actors.yml (empty/deny-by-default), and a pointer section appended to AGENTS.md. Pure scaffolding — no application code touched, consistent with this repo's "config files are sacred" upgrade guidance.

What's improved since earlier revisions

  • .agents/bin/setup now runs bundle install, npm install, and bundle exec lefthook install — it installs the pre-push hook that guards against committing local bin/swap-deps gem paths, closing a gap flagged in an earlier pass.
  • review_gate in .agents/agent-workflow.yml is now filled in with the actual gh pr ready conditions from AGENTS.md, rather than left ambiguous.

Still open (flagged inline)

  1. New autonomy grant deserves explicit sign-off: approval_exempt authorizes shared skills to auto-merge "low-risk" PRs at batch closeout with no maintainer approval — broader than AGENTS.md's existing pre-approval, which only covers marking a draft ready for review. Worth a deliberate yes/no rather than landing as part of generated boilerplate, since auto-merge is much harder to reverse.
  2. .agents/bin/validate (documented as the "Pre-push gate") runs rake spec only, skipping rubocop, even though the root Rakefile's default task bundles both and conductor-setup.sh tells contributors to run RuboCop before committing.
  3. .agents/bin/test/.agents/bin/validate only exercise the root spec/ (the lib/demo_scripts tooling), never packages/shakacode_demo_common or any demos/* app — where the actual demo code lives. bin/bootstrap-all/bin/test-all already cover that broader scope; an agent trusting this seam alone would get a false "all green" signal for the demos themselves.

Security

.agents/trusted-github-actors.yml defaults to empty lists (deny-by-default) — good. No secrets, no injection surface in the new shell wrappers (they just forward "$@" through the existing bin/conductor-exec).

No blockers beyond the three items above; recommend resolving the approval_exempt scope question explicitly before merge given it's a policy/trust change, not just tooling.

Copilot AI review requested due to automatic review settings July 15, 2026 04:21
Comment thread .agents/bin/setup Outdated
Comment thread .agents/bin/setup
@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review

Overview

Adds a repository-owned "agent-workflow seam" (.agents/agent-workflow.yml policy, .agents/bin/{setup,test,validate} wrapper scripts + README, .agents/trusted-github-actors.yml) plus a pointer section in AGENTS.md. This lets portable shared agent-workflow skills discover how to set up/test/validate this repo and read repo-specific automation policy, without those skills needing repo-specific knowledge baked in.

Code quality

  • The three new scripts follow good bash practice: set -euo pipefail, a CDPATH=-guarded cd to resolve the repo root robustly regardless of caller's cwd, and exec on the final command (correct exit code/signal propagation, no extra subshell). Executable bits are set correctly.
  • Verified .agents/bin/validate (bundle exec rake spec) and .agents/bin/test (bundle exec rspec "$@") are valid against the actual root Rakefile (RSpec::Core::RakeTask.new(:spec)) and .rspec config.
  • .agents/bin/README.md is honest about scope — capabilities with no backing command (lint, build, docs, ci-detect) are explicitly marked n/a rather than silently stubbed, which avoids agents assuming functionality that doesn't exist.
  • Two small nits left as inline comments on .agents/bin/setup:
    1. It forwards "$@" only to bundle install, not to the later npm install / lefthook install steps — likely intentional but worth documenting.
    2. Its lefthook install failure is fatal (no fallback) whereas the existing conductor-setup.sh treats that same failure as non-fatal (|| echo "⚠️ Could not install lefthook hooks"). Worth confirming that divergence is intended for agent environments (e.g. sandboxes without a real git repo) since it changes setup's failure mode.

Security

  • .agents/trusted-github-actors.yml ships with all-empty trust lists (trusted_users: [], etc.) — a safe default that grants no trust until someone opts in explicitly.
  • .agents/agent-workflow.yml's approval_exempt field is carefully scoped: it explicitly states it "grants no permanent merge authority" and defers to AGENTS.md or direct maintainer instruction. It doesn't expand on what AGENTS.md already authorizes (gh pr ready under documented conditions), but the auto-merge language is dense/easy to skim — worth a maintainer double-check that its meaning matches intent, since its real effect depends entirely on how the shared agent-workflows tooling interprets it.
  • No secrets, network calls, or new code-execution surface beyond the existing (unmodified) bin/conductor-exec.

Test coverage / risk

  • Purely additive config/tooling metadata — no application logic touched (7 files, +65/-0). Low blast radius.
  • The PR description is transparent about a validation gap: the isolated sparse worktree used to build this PR couldn't load spec_helper, so the new scripts weren't run end-to-end in this repo as part of authoring the PR. Recommend running .agents/bin/setup && .agents/bin/validate once in this actual checkout before merging, to catch any path/typo issues the sparse worktree couldn't surface.

Overall this is a low-risk, well-structured addition. The lefthook fatal/non-fatal divergence is the one item I'd want a maintainer opinion on before merging; the rest are minor documentation nits.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated 2 comments.

Comment thread .agents/bin/test Outdated
Comment thread .agents/bin/setup Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a5eb52b6cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/bin/setup Outdated
Comment thread .agents/bin/validate
Copilot AI review requested due to automatic review settings July 15, 2026 05:46
Comment thread .agents/agent-workflow.yml
Comment thread .agents/bin/README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated no new comments.

@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Summary

This PR adds a repository-owned "agent-workflow seam" (config, trust list, .agents/bin/{setup,test,validate} wrappers, and an AGENTS.md pointer), generated by shakacode/agent-workflows agent-workflow-seam-doctor. Overall it's a well-scoped, low-risk infrastructure addition — the shell scripts are correctly quoted, resolve the repo root robustly, use set -euo pipefail, and consistently delegate to the existing bin/conductor-exec wrapper.

Correctness / consistency

  • .agents/bin/{setup,test,validate} are syntactically valid, executable, and match the commands documented in .agents/bin/README.md.
  • rake spec is a real task (confirmed via the root Rakefile), so validate works as intended.
  • Left an inline note: validate (and the n/a'd lint entry) never invokes RuboCop even though it's part of this repo's actual rake default task and pre-commit hooks — acknowledged in the PR description as a temporary scoping choice due to pre-existing offenses, but worth tracking as a follow-up so agent-driven validation doesn't silently diverge from the human contract long-term.

Governance note

  • Left an inline note on .agents/agent-workflow.yml's approval_exempt field — it's a natural-language merge-authority policy that agents will interpret at run time ("auto-merge ready low-risk PRs... when separately authorized"). Not a bug, but since it's governance-sensitive (as opposed to the other purely mechanical n/a keys in that file), it's worth explicit maintainer sign-off rather than riding through as generator boilerplate.

Security

  • No secrets, no injection vectors, no unsafe eval/string-built commands. .agents/trusted-github-actors.yml ships with all-empty trust lists, which is a sensible, conservative default starting point.
  • Nothing in .github/workflows currently references these new files, so this seam is inert for existing CI and only affects agent-driven tooling — consistent with the PR's stated intent.

No blocking issues found.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 46aecffaf8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .agents/bin/setup
Copilot AI review requested due to automatic review settings July 15, 2026 06:01

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 7 changed files in this pull request and generated 1 comment.

Comment thread .agents/bin/setup
Comment thread .agents/bin/setup
@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review: Add agent workflows seam

Overview

This PR adds the repository-owned "agent-workflow seam" generated by shakacode/agent-workflows agent-workflow-seam-doctor --init: a policy file (.agents/agent-workflow.yml), an empty trust list (.agents/trusted-github-actors.yml), three wrapper scripts (.agents/bin/{setup,test,validate}) plus a README, and a short pointer section appended to AGENTS.md. It's purely additive infrastructure for portable agent tooling — no application code, demos, or existing CI workflows are touched, so the change is low-risk and easy to revert.

Verified

  • .agents/bin/{setup,test,validate} parse cleanly, are executable (100755), resolve the repo root robustly via CDPATH= cd -- "$(dirname -- "$0")/../..", and use set -euo pipefail consistently.
  • bundle exec rake spec is a real task (confirmed in the root Rakefile), so validate/test do what the README claims.
  • test/validate correctly reject any arguments (exit 64) inside an if (( $# > 0 )) guard, which doesn't trip set -e since it's the condition of the if.
  • bin/conductor-exec (pre-existing) does require zsh on PATH as the README's Preflight section states, and falls back to direct execution when mise isn't present — the seam's dependency claim is accurate.
  • .agents/trusted-github-actors.yml ships with all-empty lists, a conservative default that grants no implicit trust.
  • YAML in .agents/agent-workflow.yml is syntactically valid; nothing in .github/workflows references these new files, so the seam is inert for existing CI and only affects future agent-driven tooling.

Notes (non-blocking)

  • Left an inline comment on .agents/bin/setup: "$@" is forwarded to bundle install but silently dropped for npm install/lefthook install, unlike test/validate which reject arguments outright. Worth a comment or tightening for consistency.
  • .agents/bin/test and .agents/bin/validate are byte-for-byte identical (both just alias to rake spec). This appears to be an intentional convention from the generator (some shared skills look for test, others for validate) rather than a mistake, but it's worth confirming that's the intent rather than incidental duplication.
  • As previous reviews on this PR have noted, validate/lint deliberately skip RuboCop even though it's part of this repo's real rake default task and pre-commit hooks — acknowledged in the PR description as a scoped-down starting point. Worth tracking so agent-driven validation doesn't quietly diverge from the human contract.
  • agent-workflow.yml's approval_exempt field is a natural-language merge-authority policy that agents will interpret at run time. It's carefully hedged ("grants no permanent merge authority... only when separately authorized"), but given its governance sensitivity relative to the other n/a keys in that file, it deserves explicit maintainer sign-off rather than passing through as generator boilerplate.

No blocking issues found.

@justin808

Copy link
Copy Markdown
Member Author

Address-review summary

Scan scope: full PR history on current head d5295d322a48b79ed2eee3491adfa98ab56018d8 (no previous summary checkpoint).

Mattered

Optional

Skipped

  • None. Every current inline thread received a verified outcome and was resolved.

Current-head review threads: 0 unresolved. This review closeout does not replace the repository merge gate or hosted-check verification.

Next default scan starts after this comment. Say check all reviews to rescan the full PR.

@justin808
justin808 merged commit ac271e9 into main Jul 15, 2026
175 checks passed
@justin808
justin808 deleted the codex/seam-20260711-react-on-rails-demos branch July 15, 2026 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants