-
-
Notifications
You must be signed in to change notification settings - Fork 632
Open
Labels
codexPRs created from codex-named branchesPRs created from codex-named branches
Description
Summary
rails react_on_rails:doctor reports this warning on a freshly updated Pro/RSC demo setup:
Both build_test_command and shakapacker compile: true are configured
The warning is correct in principle, but the generated/default config currently leads to this state, so users see a warning before making any custom test-config choices.
Reproduction
- Use a Pro/RSC setup (example versions tested):
react_on_rails 16.4.0.rc.5react_on_rails_pro 16.4.0.rc.5shakapacker 9.5.0
- Keep generated/default config values:
config/initializers/react_on_rails.rbcontainsconfig.build_test_command = "RAILS_ENV=test bin/shakapacker"config/shakapacker.ymltest env hascompile: true
- Run:
bin/rails react_on_rails:doctor
Actual
Doctor warns that both approaches are configured and says they are mutually exclusive.
Expected
Either:
- Generated defaults should choose one strategy, or
- Doctor should suppress/soften this warning when it detects the untouched generator default combination.
Suggested Fix
- Make generator/test templates choose one path consistently (recommended:
compile: trueonly). - Keep doctor strict for user-customized conflicting configs, but avoid warning on known starter defaults.
Duplicate Check
I checked existing issues before filing. This is distinct from #2432 (Pro/SWC false positives), which does not cover this test-config warning.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
codexPRs created from codex-named branchesPRs created from codex-named branches