Skip to content
This repository was archived by the owner on Oct 2, 2019. It is now read-only.

Commit 4915d01

Browse files
committed
No longer inspecting result from ReactPerf.getLastMeasurements
It’s no longer recommended to use the output of `getLastMeasurements` (https://facebook.github.io/react/blog/2016/04/07/react-v15.html#reactpe rf.getlastmeasurements-is-opaque).
1 parent 39f8361 commit 4915d01

File tree

2 files changed

+2
-23
lines changed

2 files changed

+2
-23
lines changed

specs/index-spec.js

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -65,19 +65,6 @@ describe('Perf component', function() {
6565
expect(this.MockReactAddons.start).toHaveBeenCalled();
6666
});
6767

68-
it('should not print measurements if none are available', function() {
69-
const Perf = this.perf(TestComponent);
70-
this.MockReactAddons.getLastMeasurements.and.returnValue([]);
71-
72-
const perf = new Perf();
73-
perf.componentDidMount();
74-
perf.componentDidUpdate();
75-
76-
expect(this.MockReactAddons.getLastMeasurements).toHaveBeenCalled();
77-
expect(this.MockReactAddons.printWasted).not.toHaveBeenCalled();
78-
expect(this.MockConsole.log).not.toHaveBeenCalled();
79-
});
80-
8168
it('should print measurements if some are available', function() {
8269
const Perf = this.perf(TestComponent);
8370
this.MockReactAddons.getLastMeasurements.and.returnValue([{
@@ -90,7 +77,6 @@ describe('Perf component', function() {
9077

9178
expect(this.MockReactAddons.getLastMeasurements).toHaveBeenCalled();
9279
expect(this.MockReactAddons.printWasted).toHaveBeenCalled();
93-
expect(this.MockConsole.log).toHaveBeenCalled();
9480
});
9581
});
9682
});

src/index.js

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,15 +19,8 @@ export default function perf(Component) {
1919
componentDidUpdate() {
2020
const measurements = ReactPerf.getLastMeasurements();
2121

22-
if (measurements.length > 0) {
23-
this.totalRenders = (this.totalRenders || 0) + 1;
24-
this.totalTime = (this.totalTime || 0) + measurements[0].totalTime;
25-
26-
console.log(`Average: ${this.totalTime / this.totalRenders} over ${this.totalRenders} renders.`);
27-
28-
ReactPerf.printWasted(measurements);
29-
ReactPerf.start();
30-
}
22+
ReactPerf.printWasted(measurements);
23+
ReactPerf.start();
3124
}
3225
render() {
3326
return <Component {...this.props} />;

0 commit comments

Comments
 (0)