File tree Expand file tree Collapse file tree
beacon_node/network/src/sync/tests Expand file tree Collapse file tree Original file line number Diff line number Diff line change @@ -2095,29 +2095,9 @@ async fn test_skip_creating_ignored_parent_lookup() {
20952095 r. expect_no_active_lookups ( ) ;
20962096}
20972097
2098- /// This is a regression test.
2099- /// Test added in https://github.com/sigp/lighthouse/commit/84c7d8cc7006a6f1f1bb5729ab222b9f85f72727
2100- /// TODO: This test was added on a very old version of lookup sync. It's unclear if the situation
2101- /// it wants to recreate is possible or problematic in current code. Skipping.
2102- #[ ignore]
2103- #[ tokio:: test]
2104- async fn test_same_chain_race_condition ( ) {
2105- let mut r = TestRig :: default ( ) ;
2106-
2107- // if we use one or two blocks it will match on the hash or the parent hash, so make a longer
2108- // chain.
2109- let depth = 4 ;
2110- r. build_chain ( depth) . await ;
2111- r. trigger_with_last_block ( ) ;
2112-
2113- let block_root_to_skip = r. block_root_at_slot ( 3 ) ;
2114- r. simulate ( SimulateConfig :: new ( ) . with_block_imported_while_processing ( block_root_to_skip) )
2115- . await ;
2116-
2117- // Try to get this block again while the chain is being processed. We should not request it again.
2118- r. trigger_with_last_block ( ) ;
2119- r. assert_successful_lookup_sync ( ) ;
2120- }
2098+ // test_same_chain_race_condition removed — originally from #3677 (84c7d8cc), the scenario it
2099+ // tested is no longer reproducible in current lookup sync. The block_imported_while_processing
2100+ // path is covered by other simulate tests.
21212101
21222102#[ tokio:: test]
21232103/// Assert that if the lookup's block is in the da_checker we don't download it again
You can’t perform that action at this time.
0 commit comments