feat(store): Add PostgresDB backend with basic get/put and tests #7685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eserilev
reviewed
Jul 3, 2025
| ); | ||
|
|
||
| INSERT INTO store (col, key, value) | ||
| VALUES ('example', decode('aabbcc', 'hex'), decode('112233', 'hex')); |
There was a problem hiding this comment.
I dont think we need this file?
eserilev
reviewed
Jul 3, 2025
Comment on lines
1
to
27
| use store::database::postgres_impl::PostgresDB; | ||
| use store::{AsyncKeyValueStore, DBColumn}; | ||
| use types::MainnetEthSpec; | ||
|
|
||
| #[tokio::test] | ||
| async fn test_postgres_store() { | ||
| dotenvy::dotenv().ok(); | ||
|
|
||
| let db_url = std::env::var("DATABASE_URL").expect("DATABASE_URL must be set"); | ||
|
|
||
| let db = PostgresDB::<MainnetEthSpec>::new(&db_url) | ||
| .await | ||
| .expect("failed to connect"); | ||
|
|
||
| let key = b"test_key"; | ||
| let value = b"test_value"; | ||
|
|
||
| db.put_bytes(DBColumn::BeaconBlock, key, value) | ||
| .await | ||
| .expect("put failed"); | ||
|
|
||
| let result = db.get_bytes(DBColumn::BeaconBlock, key) | ||
| .await | ||
| .expect("get failed"); | ||
|
|
||
| assert_eq!(result, Some(value.to_vec())); | ||
| } |
There was a problem hiding this comment.
We can delete this test eventually. We should instead enable our test suite to run with a postgres db backend enabled
|
Looks like a good start. I don't think we'll want to provide a database url via env variable, we'll probably want to do that via a cli flag. |
|
@eserilev I've pushed new commits addressing the recent work on the Postgres backend. It's ready for review when you have time. Let me know what you think. |
eserilev
reviewed
Jul 16, 2025
beacon_node/store/Cargo.toml
Outdated
| tracing = { workspace = true } | ||
| tracing-subscriber = { workspace = true } | ||
| types = { workspace = true } | ||
| xdelta3 = { workspace = true } | ||
| zstd = { workspace = true } | ||
| dotenvy = "0.15.7" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Supersedes: #7639
Context: Initial draft PR for adding a PostgresDB backend to the Beacon Node store.
Proposed Changes
PostgresDBbackend implementation tostorecrate.get_bytesput_bytestests/postgres_store.rsthat exercises these methods using a real Postgres database.Additional Info
interface.rs.do_atomically,key_exists, etc.) will be added after initial review, wiring, and interface agreement.@eserilev