Skip to content

Deprectate Order->Total() as it conflicts with casting of Total DB field #811

@wernerkrauss

Description

@wernerkrauss

How about deprecating Order's Total() method and suggest using it's alias instead, GrandTotal()?

It conflicts with casting of Total DB field for e.g. GridField when I want to dispay it with European decimal numbers. (See related #779)

This can be done in the next SS5 main release, as it's a breaking change and I don't know how many modules (or custom installations) use it right now.

Of course we can add a rector for easier upgrading to silverstripe-rector

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions