diff --git a/.github/workflows/lint-test.yml b/.github/workflows/lint-test.yml index 9dbbdd2d3..4ec5df118 100644 --- a/.github/workflows/lint-test.yml +++ b/.github/workflows/lint-test.yml @@ -83,7 +83,7 @@ jobs: uses: actions/cache@v4 with: path: ~/.local - key: poetry-4 # increment to reset cache + key: poetry-5 # increment to reset cache - name: Install Poetry 📜 if: steps.poetry.outputs.cache-hit != 'true' @@ -96,7 +96,7 @@ jobs: uses: actions/cache@v4 with: path: ~/.cache/pypoetry/virtualenvs - key: poetry-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}-7 # increment to reset cache + key: poetry-${{ runner.os }}-${{ hashFiles('**/poetry.lock') }}-8 # increment to reset cache - name: Create Poetry environments 📜 if: steps.poetry-venvs.outputs.cache-hit != 'true' diff --git a/apps/storybook/src/DataCurve.stories.tsx b/apps/storybook/src/DataCurve.stories.tsx index 0f204539a..68cdd3fed 100644 --- a/apps/storybook/src/DataCurve.stories.tsx +++ b/apps/storybook/src/DataCurve.stories.tsx @@ -30,7 +30,6 @@ const meta = { args: { abscissas: range(oneD.size), ordinates: oneD.data, - errors: oneD.data.map(() => 10), curveType: CurveType.LineOnly, color: 'blue', materialProps: {}, @@ -53,13 +52,13 @@ type Story = StoryObj; export const Default = { render: (args) => { - const { abscissas, ordinates, errors, showErrors, ignoreValue } = args; + const { abscissas, ordinates, errors, ignoreValue } = args; const abscissaDomain = useDomain(abscissas); const ordinateDomain = useDomain( ordinates, ScaleType.Linear, - showErrors ? errors : undefined, + errors, ignoreValue, ); @@ -117,7 +116,7 @@ export const Glyphs = { export const WithErrors = { ...Default, args: { - showErrors: true, + errors: oneD.data.map(() => 10), }, } satisfies Story; diff --git a/packages/app/src/vis-packs/core/line/LineToolbar.tsx b/packages/app/src/vis-packs/core/line/LineToolbar.tsx index 9c72b402d..3bd3c06dd 100644 --- a/packages/app/src/vis-packs/core/line/LineToolbar.tsx +++ b/packages/app/src/vis-packs/core/line/LineToolbar.tsx @@ -27,20 +27,14 @@ interface Props { dataDomain: Domain; isSlice?: boolean; isComplex?: boolean; - disableErrors?: boolean; + withErrors?: boolean; config: LineConfig; exportEntries?: ExportEntry[]; } function LineToolbar(props: Props) { - const { - dataDomain, - isSlice, - isComplex, - disableErrors, - config, - exportEntries, - } = props; + const { dataDomain, isSlice, isComplex, withErrors, config, exportEntries } = + props; const { customDomain, @@ -97,13 +91,12 @@ function LineToolbar(props: Props) { - {!isComplex && ( + {withErrors && ( )} diff --git a/packages/app/src/vis-packs/core/line/MappedLineVis.tsx b/packages/app/src/vis-packs/core/line/MappedLineVis.tsx index 988d3418e..7b3da693f 100644 --- a/packages/app/src/vis-packs/core/line/MappedLineVis.tsx +++ b/packages/app/src/vis-packs/core/line/MappedLineVis.tsx @@ -154,7 +154,7 @@ function MappedLineVis(props: Props) { , diff --git a/packages/lib/src/vis/line/DataCurve.tsx b/packages/lib/src/vis/line/DataCurve.tsx index 0c7b97ce4..3042d5bee 100644 --- a/packages/lib/src/vis/line/DataCurve.tsx +++ b/packages/lib/src/vis/line/DataCurve.tsx @@ -35,7 +35,7 @@ function DataCurve(props: Props) { abscissas, ordinates, errors, - showErrors, + showErrors = true, color, width, interpolation, diff --git a/packages/lib/src/vis/line/LineVis.tsx b/packages/lib/src/vis/line/LineVis.tsx index c95e57c5c..e88d11df0 100644 --- a/packages/lib/src/vis/line/LineVis.tsx +++ b/packages/lib/src/vis/line/LineVis.tsx @@ -62,7 +62,7 @@ function LineVis(props: Props) { title, dtype, errorsArray, - showErrors = false, + showErrors = true, auxiliaries = [], renderTooltip, children,