Remove wrong assertion

tvdijen · tvdijen · commit 5b6960fd1748 · 2022-01-08T23:32:35.000+01:00
diff --git a/lib/Shib13/AuthnResponse.php b/lib/Shib13/AuthnResponse.php
@@ -208,10 +208,9 @@ private function doXPathQuery(string $query, DOMNode $node = null): DOMNodeList
      */
     public function getSessionIndex(): ?string
     {
-        Assert::isInstanceOf($node, DOMNode::class);
-
         $query = '/shibp:Response/shib:Assertion/shib:AuthnStatement';
         $nodelist = $this->doXPathQuery($query);
+
         if ($node = $nodelist->item(0)) {
             return $node->getAttribute('SessionIndex');
         }

Original file line number	Diff line number	Diff line change
`@@ -208,10 +208,9 @@ private function doXPathQuery(string $query, DOMNode $node = null): DOMNodeList`
`208`	`208`	`*/`
`209`	`209`	`public function getSessionIndex(): ?string`
`210`	`210`	`{`
`211`		`- Assert::isInstanceOf($node, DOMNode::class);`
`212`		`-`
`213`	`211`	`$query = '/shibp:Response/shib:Assertion/shib:AuthnStatement';`
`214`	`212`	`$nodelist = $this->doXPathQuery($query);`
	`213`	`+`
`215`	`214`	`if ($node = $nodelist->item(0)) {`
`216`	`215`	`return $node->getAttribute('SessionIndex');`
`217`	`216`	`}`