Grade emails aren't sent consistently

[lieuwex]

As reported by a friend, he said that a new grade B7de6PTs8yDpWAMma was notified by mail, but grade 2zz6dtDpjSsdruAmR wasn't.

[lieuwex]

It seems it hasn't been sent at all, so it's not a bounce or smth at sparkpost

So, it has to be something with the eventhandler. Probably

[lieuwex]

@marcus-talbot We don't use an event handler, we check every 15 minutes using a cron job: https://github.com/simplyGits/simplyHomework/blob/develop/packages/notices/server/emails.js#L32-L107

Didn't look at it properly yet, but maybe it notices new grades, sends a mail for the first new grade id, and then just returns, skipping the rest of the grades all together?

[tomsmeding]

I see that you filter on grades that are newly entered in the past 15 minutes in a repeating job that runs every 15 minutes. How accurate is the syncedcron timer? Maybe it's possible that a grade is entered RIGHT after your syncedcron job and syncedcron is a bit slow in launching the next one, so that the grade is too late for the previous run, but just too early for the next.

[lieuwex]

@marcus-talbot could be, I think I have tested it though but I can take a look

@tomsmeding Yeah I was thinking of something like that too, I have to dive into the logs to see that, I will when I've time.