Skip to content

Commit eddfb93

Browse files
JPPortierJPPortier
committed
refactor (Numbers): Naming enhancements
1 parent 6c30c9f commit eddfb93

15 files changed

+32
-32
lines changed

‎snippets/src/main/java/numbers/CheckAvailability.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ public static void main(String[] args) {
3535

3636
SinchClient client = new SinchClient(configuration);
3737

38-
NumbersService service = client.numbers().v1();
38+
NumbersService numbersService = client.numbers().v1();
3939

4040
LOGGER.info("CheckAvailability for: " + phoneNumber);
4141

42-
AvailableNumber value = service.checkAvailability(phoneNumber);
42+
AvailableNumber value = numbersService.checkAvailability(phoneNumber);
4343

4444
LOGGER.info("Response: " + value);
4545
}

‎snippets/src/main/java/numbers/DeprovisionEmergencyAddress.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,10 +34,10 @@ public static void main(String[] args) {
3434

3535
SinchClient client = new SinchClient(configuration);
3636

37-
NumbersService service = client.numbers().v1();
37+
NumbersService numbersService = client.numbers().v1();
3838

3939
LOGGER.info("De-provisioning EmergencyAddress for: " + phoneNumber);
4040

41-
service.deprovisionEmergencyAddress(phoneNumber);
41+
numbersService.deprovisionEmergencyAddress(phoneNumber);
4242
}
4343
}

‎snippets/src/main/java/numbers/Get.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,10 @@ public static void main(String[] args) {
3535

3636
SinchClient client = new SinchClient(configuration);
3737

38-
NumbersService service = client.numbers().v1();
38+
NumbersService numbersService = client.numbers().v1();
3939

4040
LOGGER.info("Get for: " + phoneNumber);
41-
ActiveNumber value = service.get(phoneNumber);
41+
ActiveNumber value = numbersService.get(phoneNumber);
4242

4343
LOGGER.info("Response: " + value);
4444
}

‎snippets/src/main/java/numbers/GetEmergencyAddress.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ public static void main(String[] args) {
2222
String projectId = Settings.getProjectId().orElse("MY_PROJECT_ID");
2323
String keyId = Settings.getKeyId().orElse("MY_KEY_ID");
2424
String keySecret = Settings.getKeySecret().orElse("MY_KEY_SECRET");
25-
;
2625

2726
String phoneNumber = Settings.getPhoneNumber().orElse("MY_SINCH_PHONE_NUMBER");
2827

@@ -35,11 +34,11 @@ public static void main(String[] args) {
3534

3635
SinchClient client = new SinchClient(configuration);
3736

38-
NumbersService service = client.numbers().v1();
37+
NumbersService numbersService = client.numbers().v1();
3938

4039
LOGGER.info("Get EmergencyAddress for: " + phoneNumber);
4140

42-
EmergencyAddress response = service.getEmergencyAddress(phoneNumber);
41+
EmergencyAddress response = numbersService.getEmergencyAddress(phoneNumber);
4342

4443
LOGGER.info("Response: " + response);
4544
}

‎snippets/src/main/java/numbers/List.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ public static void main(String[] args) {
3535

3636
SinchClient client = new SinchClient(configuration);
3737

38-
NumbersService service = client.numbers().v1();
38+
NumbersService numbersService = client.numbers().v1();
3939

4040
LOGGER.info("Listing active numbers");
4141

4242
ActiveNumberListResponse response =
43-
service.list(
43+
numbersService.list(
4444
ActiveNumbersListQueryParameters.builder()
4545
.setRegionCode("US")
4646
.setType(NumberType.LOCAL)

‎snippets/src/main/java/numbers/ProvisionEmergencyAddress.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public static void main(String[] args) {
3636

3737
SinchClient client = new SinchClient(configuration);
3838

39-
NumbersService service = client.numbers().v1();
39+
NumbersService numbersService = client.numbers().v1();
4040

4141
LOGGER.info("Provisioning EmergencyAddress for: " + phoneNumber);
4242

@@ -54,7 +54,7 @@ public static void main(String[] args) {
5454
.setDisplayName("Emergency Address Display Name")
5555
.setAddress(emergencyAddress)
5656
.build();
57-
EmergencyAddress value = service.provisionEmergencyAddress(phoneNumber, request);
57+
EmergencyAddress value = numbersService.provisionEmergencyAddress(phoneNumber, request);
5858

5959
LOGGER.info("Response: " + value);
6060
}

‎snippets/src/main/java/numbers/Release.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ public static void main(String[] args) {
3535

3636
SinchClient client = new SinchClient(configuration);
3737

38-
NumbersService service = client.numbers().v1();
38+
NumbersService numbersService = client.numbers().v1();
3939

4040
LOGGER.info("Release for: " + phoneNumber);
4141

42-
ActiveNumber value = service.release(phoneNumber);
42+
ActiveNumber value = numbersService.release(phoneNumber);
4343

4444
LOGGER.info("Response: " + value);
4545
}

‎snippets/src/main/java/numbers/Rent.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,15 @@ public static void main(String[] args) {
4343

4444
SinchClient client = new SinchClient(configuration);
4545

46-
NumbersService service = client.numbers().v1();
46+
NumbersService numbersService = client.numbers().v1();
4747

4848
SmsConfiguration smsConfiguration =
4949
SmsConfiguration.builder().setServicePlanId(servicePlanIdToAssociateWithTheNumber).build();
5050

5151
AvailableNumberRentRequest parameters =
5252
AvailableNumberRentRequest.builder().setSmsConfiguration(smsConfiguration).build();
5353

54-
ActiveNumber response = service.rent(phoneNumberToBeRented, parameters);
54+
ActiveNumber response = numbersService.rent(phoneNumberToBeRented, parameters);
5555

5656
LOGGER.info(String.format("Rented number: %s", response));
5757
}

‎snippets/src/main/java/numbers/RentAny.java‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ public static void main(String[] args) {
2727
String keyId = Settings.getKeyId().orElse("MY_KEY_ID");
2828
String keySecret = Settings.getKeySecret().orElse("MY_KEY_SECRET");
2929

30-
String servicePlanIdToAssociateWithTheNumber = Settings.getServicePlanId().orElse("MY_SERVICE_PLAN_ID");
30+
String servicePlanIdToAssociateWithTheNumber =
31+
Settings.getServicePlanId().orElse("MY_SERVICE_PLAN_ID");
3132

3233
// Available regions can be retrieved by using list() function from regions service, see
3334
// the numbers/regions/List snippet or
@@ -45,7 +46,7 @@ public static void main(String[] args) {
4546

4647
SinchClient client = new SinchClient(configuration);
4748

48-
NumbersService service = client.numbers().v1();
49+
NumbersService numbersService = client.numbers().v1();
4950

5051
SmsConfiguration smsConfiguration =
5152
SmsConfiguration.builder().setServicePlanId(servicePlanIdToAssociateWithTheNumber).build();
@@ -57,7 +58,7 @@ public static void main(String[] args) {
5758
.setSmsConfiguration(smsConfiguration)
5859
.build();
5960

60-
ActiveNumber response = service.rentAny(parameters);
61+
ActiveNumber response = numbersService.rentAny(parameters);
6162

6263
LOGGER.info(String.format("Rented number: %s", response));
6364
}

‎snippets/src/main/java/numbers/SearchForAvailableNumbers.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public static void main(String[] args) {
3838

3939
SinchClient client = new SinchClient(configuration);
4040

41-
NumbersService service = client.numbers().v1();
41+
NumbersService numbersService = client.numbers().v1();
4242

4343
AvailableNumbersListQueryParameters parameters =
4444
AvailableNumbersListQueryParameters.builder()
@@ -48,7 +48,7 @@ public static void main(String[] args) {
4848

4949
LOGGER.info("Looking for available numbers");
5050

51-
AvailableNumberListResponse response = service.searchForAvailableNumbers(parameters);
51+
AvailableNumberListResponse response = numbersService.searchForAvailableNumbers(parameters);
5252

5353
response
5454
.iterator()

0 commit comments

Comments
 (0)