Support languages like Chinese, Japanese, Thai, etc.

[saginadir]

It's a cool library, but i'm fearful that it won't slugify everything.

Chinese characters are just deleted.

slugify('你好'); // results in an empty string

[Sigmus]

I'm curious, what would be the preferable result in this case?

[saginadir]

It is possible to convert Chinese to pinyin for example:
https://stackoverflow.com/questions/4813086/how-to-convert-chinese-characters-to-pinyin

[caraya]

Reading that answer it appears that there is no single way to slugify Chinese characters. Even converting them to Pinyin it would be very hard to provide the correct conversion, as the last answer in the question you linked to points out.

If you have the translations handy you can add them to your project and then slugify the translation. That would probably be easier than asking slugify to also convert from one language to the other. I believe that's outside the scope of what the library was designed to do

[XieJiSS]

Could we just leave CJK characters unchanged? Like Hello你好 -> hello-你好

Wikipedia URLs contain unicode characters in their paths, so I figured that was OK and I was looking for a lib to do the same for my non-English site.

[sindresorhus]

Could we just leave CJK characters unchanged? Like Hello你好 -> hello-你好

PR welcome for an opt-in options for it.

[lizhengnacl]

mark

[brandonpittman]

@sindresorhus Yeah, "Ignores Chinese" is a bad title.

The Japanese get no love either. 残念。。。

[sindresorhus]

@brandonpittman I definitely intend to support languages like Chinese, Japanese, Thai, etc, but it's more work and will take some time. Help is always welcome though.

[sindresorhus]

If anyone wants to work on this, see the feedback given in sindresorhus/slugify#30.