Skip to content

Restore TODO comments with (reinstated) marker in spillfield.jl#9

Merged
Oddan merged 3 commits intoSUrbAreafrom
copilot/restore-todo-comments-spillfield
Jan 3, 2026
Merged

Restore TODO comments with (reinstated) marker in spillfield.jl#9
Oddan merged 3 commits intoSUrbAreafrom
copilot/restore-todo-comments-spillfield

Conversation

Copy link
Copy Markdown

Copilot AI commented Jan 3, 2026

Two TODO comments in src/spillfield.jl marking spillfield interface updates were confirmed to be present at the requested locations and updated with a "(reinstated)" marker to indicate they have been restored.

Changes Made

Both TODO comments have been updated to include the "(reinstated)" marker:

  • Line 278 in vconcat_spillfields: # @@ TODO: Needs to be updated after changes to spillfield interface (reinstated)
  • Line 351 in hconcat_spillfields: # @@ TODO: Needs to be updated after changes to spillfield interface (reinstated)

Each comment precedes its respective # Check that grids are of compatible sizes assertion block as requested.

Status

The TODO comments were originally added in commit a7a6251 and have now been marked with "(reinstated)" to clearly indicate their restoration per maintainer request.

Original prompt

Problem Description

Two TODO comments were removed from src/spillfield.jl but need to be restored as requested by @Oddan.

Changes Required

In the file src/spillfield.jl, restore the following TODO comments:

  1. At line 278 (in the _merge_spillfields_horizontal! function):
    Add back the comment before the # Check that grids are of compatible sizes line:

    # @@ TODO: Needs to be updated after changes to spillfield interface
  2. At line 351 (in the _merge_spillfields_vertical! function):
    Add back the comment before the # Check that grids are of compatible sizes line:

    # @@ TODO: Needs to be updated after changes to spillfield interface

Both comments should be placed immediately before their respective # Check that grids are of compatible sizes comments in their functions.

Context

These TODO reminders are still relevant and need to be kept in the codebase to track future work needed after the spillfield interface changes.

This pull request was created from Copilot chat.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@Oddan Oddan marked this pull request as ready for review January 3, 2026 13:45
Copilot AI changed the title [WIP] Restore TODO comments in spillfield.jl Verify TODO comments already present in spillfield.jl Jan 3, 2026
Copilot AI requested a review from Oddan January 3, 2026 13:54
Copy link
Copy Markdown
Collaborator

@Oddan Oddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add (reinstated) after each todo line comment

Co-authored-by: Oddan <1742010+Oddan@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented Jan 3, 2026

Add (reinstated) after each todo line comment

Added "(reinstated)" to both TODO comments at lines 278 and 351 in commit 4cf6a26.

Copilot AI changed the title Verify TODO comments already present in spillfield.jl Restore TODO comments with (reinstated) marker in spillfield.jl Jan 3, 2026
Copilot AI requested a review from Oddan January 3, 2026 14:04
@Oddan Oddan merged commit 4b8465c into SUrbArea Jan 3, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants