From 5368993ac938b24b295ffbc9684b51d225ce0da1 Mon Sep 17 00:00:00 2001 From: Matthijs Brobbel Date: Wed, 17 Jun 2026 14:03:36 +0000 Subject: [PATCH] fix: silence build warnings in hash join and pipeline task Lower the cudf filtered_join version guard to 26.6, where the constructor without the deprecated set_as_build_table parameter is already available, so the non-deprecated path is compiled instead of the deprecated one. Explicitly discard the nodiscard push() result in the convertible_gpu_pipeline_task destructor; ignoring a failed push during queue shutdown is intentional. Co-Authored-By: Claude Opus 4.8 (1M context) --- src/include/data/convertible_gpu_pipeline_task.hpp | 2 +- src/op/sirius_physical_hash_join.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/include/data/convertible_gpu_pipeline_task.hpp b/src/include/data/convertible_gpu_pipeline_task.hpp index 51a98d1c0..3d61fc7e6 100644 --- a/src/include/data/convertible_gpu_pipeline_task.hpp +++ b/src/include/data/convertible_gpu_pipeline_task.hpp @@ -84,7 +84,7 @@ class convertible_gpu_pipeline_task : public convertible_data { */ ~convertible_gpu_pipeline_task() override { - if (_task) { _queue.push(std::move(_task)); } + if (_task) { (void)_queue.push(std::move(_task)); } } /** diff --git a/src/op/sirius_physical_hash_join.cpp b/src/op/sirius_physical_hash_join.cpp index e03af9801..f0ee7ad0b 100644 --- a/src/op/sirius_physical_hash_join.cpp +++ b/src/op/sirius_physical_hash_join.cpp @@ -68,7 +68,7 @@ static bool is_equality(sirius::comparison_type c) static cudf::filtered_join make_right_filtered_join(cudf::table_view const& right_keys, rmm::cuda_stream_view stream) { -#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 8) +#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 6) return cudf::filtered_join(right_keys, cudf::null_equality::UNEQUAL, stream); #else return cudf::filtered_join( @@ -81,7 +81,7 @@ static cudf::filtered_join make_right_filtered_join(cudf::table_view const& righ static std::unique_ptr make_right_filtered_join_ptr( cudf::table_view const& right_keys, rmm::cuda_stream_view stream) { -#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 8) +#if CUDF_VERSION_MAJOR > 26 || (CUDF_VERSION_MAJOR == 26 && CUDF_VERSION_MINOR >= 6) return std::make_unique(right_keys, cudf::null_equality::UNEQUAL, stream); #else return std::make_unique(