Merge pull request #43 from visol-forks/bugfix/property-check-strict-comparison

mficzel · web-flow · commit 3cbd9fbfe2b6 · 2025-02-13T18:23:21.000+01:00
BUGFIX: When translating, use strict comparison for checking identical property values
diff --git a/Classes/ContentRepository/NodeTranslationService.php b/Classes/ContentRepository/NodeTranslationService.php
@@ -218,7 +218,7 @@ public function translateNode(NodeInterface $sourceNode, NodeInterface $targetNo
                 $propertyValue = $this->nodeUriPathSegmentGenerator->generateUriPathSegment(null, $propertyValue);
             }
 
-            if ($targetNode->getProperty($propertyName) != $propertyValue) {
+            if ($targetNode->getProperty($propertyName) !== $propertyValue) {
                 $targetNode->setProperty($propertyName, $propertyValue);
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -218,7 +218,7 @@ public function translateNode(NodeInterface $sourceNode, NodeInterface $targetNo`
`218`	`218`	`$propertyValue = $this->nodeUriPathSegmentGenerator->generateUriPathSegment(null, $propertyValue);`
`219`	`219`	`}`
`220`	`220`
`221`		`- if ($targetNode->getProperty($propertyName) != $propertyValue) {`
	`221`	`+ if ($targetNode->getProperty($propertyName) !== $propertyValue) {`
`222`	`222`	`$targetNode->setProperty($propertyName, $propertyValue);`
`223`	`223`	`}`
`224`	`224`	`}`