[release] remove deprecations for 0.10 and 0.11 (#8061)

* [release] remove deprecations for 0.10 and 0.11

* lint

* minor updates

* test fixes

* revert docs changes

* revert skypilot-cluster label removal - bump to 0.12.0

Author: cg505

charts/external-metrics/values.yaml

@@ -11,7 +11,7 @@ prometheus:
       size: 10Gi
   kube-state-metrics:
     enabled: true
-    # TODO (kyuds): remove skypilot-cluster label in v0.11.0; deprecated in favor of skypilot-cluster-name.
+    # TODO (kyuds): remove skypilot-cluster label in v0.12.0; deprecated in favor of skypilot-cluster-name.
     metricLabelsAllowlist:
       - pods=[skypilot-cluster,skypilot-cluster-name]
   prometheus-node-exporter:

charts/skypilot/templates/api-deployment.yaml

@@ -226,18 +226,8 @@ spec:
           done
           {{- end }}
 
-          if sky api start -h | grep -q -- "--foreground"; then
-            mkdir -p /root/.sky/api_server
-            exec sky api start {{ include "skypilot.apiArgs" . }} --foreground  2>&1 | tee -a /root/.sky/api_server/server.log
-          else
-            # For backward compatibility, run in background if --foreground is not supported.
-            # TODO(aylei): this will be dropped in 0.11.0.
-            if sky api start {{ include "skypilot.apiArgs" . }}; then
-              tail -n+0 -f /root/.sky/api_server/server.log
-            else
-              cat /root/.sky/api_server/server.log
-            fi
-          fi
+          mkdir -p /root/.sky/api_server
+          exec sky api start {{ include "skypilot.apiArgs" . }} --foreground  2>&1 | tee -a /root/.sky/api_server/server.log
         ports:
         - containerPort: 46580
         livenessProbe:

charts/skypilot/templates/ingress-nodeport.yaml

@@ -1,8 +1,4 @@
 {{- if .Values.rbac.create }}
-{{/* TODO(aylei): removed in v0.11.0 */}}
-{{- if .Values.rbac.rules }}
-{{- fail "`.rbac.rules` is deprecated. Please use `.rbac.namespaceRules` and `.rbac.clusterRules` instead" }}
-{{- end }}
 ---
 apiVersion: v1
 kind: ServiceAccount

charts/skypilot/templates/rbac.yaml

@@ -342,18 +342,6 @@
                         "null"
                     ]
                 },
-                "httpNodePort": {
-                    "type": [
-                        "number",
-                        "null"
-                    ]
-                },
-                "httpsNodePort": {
-                    "type": [
-                        "number",
-                        "null"
-                    ]
-                },
                 "ingressClassName": {
                     "type": "string"
                 },

charts/skypilot/values.schema.json

@@ -286,28 +286,6 @@ ingress:
   # @schema type: [object, null]
   annotations: null
 
-  # Whether enable an additional NodePort service for the ingress controller
-  # Default to null for backward compatibility:
-  # - For existing deployments, error out and ask users to set ingress.nodePortEnabled explicitly
-  # - For new deployments, disable the NodePort service, equivalent to ingress.nodePortEnabled=false
-  # So, for deployments that use default values, upgrade from 0.8.0 nightly will:
-  # - Ask users to set ingress.nodePortEnabled explicitly
-  # - Create a new LoadBalancer endpoint since ingress-nginx.controller.service.type is now default to LoadBalancer
-  # It is recommended to keep only one endpoint by explicitly setting ingress.nodePortEnabled=false and switch to ingress-nginx.controller.service.type
-  # if you are upgrading from 0.8.0 nightly.
-  # Deprecated: use ingress-nginx.controller.service.type=NodePort instead
-  # TODO(aylei): remove these fields in v0.10.0
-  # @schema hidden: true
-  nodePortEnabled: null
-  # Specific nodePort to use for the ingress controller
-  # If not set, Kubernetes will assign random ports in the NodePort range (default 30000-32767)
-  # Deprecated: use ingress-nginx.controller.service.nodePorts.http instead
-  # @schema type: [number, null]
-  httpNodePort: 30050 # Set to null to automatically assign a random port
-  # Deprecated: use ingress-nginx.controller.service.nodePorts.https instead
-  # @schema type: [number, null]
-  httpsNodePort: 30051 # Set to null to automatically assign a random port
-
   # TODO(aylei): deprecate skypilot managed proxy auth to reduce our maintenance burden, replace with examples instead.
   # OAuth2 Proxy configuration for authentication
   oauth2-proxy:
@@ -617,7 +595,7 @@ prometheus:
     {{ end}}
   kube-state-metrics:
     enabled: true
-    # TODO (kyuds): remove skypilot-cluster label in v0.11.0; deprecated in favor of skypilot-cluster-name.
+    # TODO (kyuds): remove skypilot-cluster label in v0.12.0; deprecated in favor of skypilot-cluster-name.
     metricLabelsAllowlist:
       - pods=[skypilot-cluster,skypilot-cluster-name]
   prometheus-node-exporter:

charts/skypilot/values.yaml

@@ -947,29 +947,6 @@ If you want to use an existing service account and permissions that meet the :re
       --set rbac.serviceAccountName=my-existing-service-account
 
 
-.. _sky-migrate-legacy-service:
-
-.. dropdown:: Migrate from legacy NodePort service
-
-
-    If you are upgrading from an early 0.8.0 nightly with a previously deployed NodePort service (named ``${RELEASE_NAME}-ingress-controller-np``), an error will be raised to ask for migration. In addition, a new service will be created to expose the API server (using ``LoadBalancer`` service type by default). You can choose any of the following options to proceed the upgrade process based on your needs:
-
-    - Keep the legacy NodePort service and gradually migrate to the new LoadBalancer service:
-
-    Add ``--set ingress.nodePortEnabled=true`` to your ``helm upgrade`` command to keep the legacy NodePort service. Existing clients can continue to use the previous NodePort service. After all clients have been migrated to the new service, you can disable the legacy NodePort service by adding ``--set ingress.nodePortEnabled=false`` to the ``helm upgrade`` command.
-
-    - Disable the legacy NodePort service:
-
-    Add ``--set ingress.nodePortEnabled=false`` to your ``helm upgrade`` command to disable the legacy NodePort service. Clients will need to use the new service to connect to the API server.
-
-    .. note::
-
-        Make sure there is no clients using the NodePort service before disabling it.
-
-    .. note::
-
-        Refer to :ref:`sky-get-api-server-url` for how to customize and/or connect to the new service.
-
 .. _sky-api-server-helm-multiple-deploy:
 
 Reusing ingress controller for API server

docs/source/reference/api-server/api-server-admin-deploy.rst

@@ -114,9 +114,6 @@ Below is the available helm value keys and the default value of each key:
     :ref:`host <helm-values-ingress-host>`: null
     :ref:`path <helm-values-ingress-path>`: '/'
     :ref:`ingressClassName <helm-values-ingress-ingressClassName>`: nginx
-    :ref:`nodePortEnabled <helm-values-ingress-nodePortEnabled>`: null
-    :ref:`httpNodePort <helm-values-ingress-httpNodePort>`: 30050
-    :ref:`httpsNodePort <helm-values-ingress-httpsNodePort>`: 30051
     :ref:`annotations <helm-values-ingress-annotations>`: null
     # Deprecated: use auth.oauth instead.
     :ref:`oauth2-proxy <helm-values-ingress-oauth2-proxy>`:
@@ -1254,48 +1251,6 @@ Default: ``nginx``
   ingress:
     ingressClassName: nginx
 
-.. _helm-values-ingress-nodePortEnabled:
-
-``ingress.nodePortEnabled``
-^^^^^^^^^^^^^^^^^^^^^^^^^^^
-
-Whether to enable an additional NodePort service for the ingress controller. Deprecated: use ``ingress-nginx.controller.service.type=NodePort`` instead.
-
-Default: ``null``
-
-.. code-block:: yaml
-
-  ingress:
-    nodePortEnabled: false
-
-.. _helm-values-ingress-httpNodePort:
-
-``ingress.httpNodePort``
-^^^^^^^^^^^^^^^^^^^^^^^^
-
-Specific nodePort to use for HTTP traffic. Deprecated: use ``ingress-nginx.controller.service.nodePorts.http`` instead.
-
-Default: ``30050``
-
-.. code-block:: yaml
-
-  ingress:
-    httpNodePort: 30050
-
-.. _helm-values-ingress-httpsNodePort:
-
-``ingress.httpsNodePort``
-^^^^^^^^^^^^^^^^^^^^^^^^^
-
-Specific nodePort to use for HTTPS traffic. Deprecated: use ``ingress-nginx.controller.service.nodePorts.https`` instead.
-
-Default: ``30051``
-
-.. code-block:: yaml
-
-  ingress:
-    httpsNodePort: 30051
-
 .. _helm-values-ingress-annotations:
 
 ``ingress.annotations``

docs/source/reference/api-server/helm-values-spec.rst

@@ -1064,11 +1064,7 @@ def write_cluster_config(
         with open(tmp_yaml_path, 'w', encoding='utf-8') as f:
             f.write(restored_yaml_content)
 
-    # Read the cluster name from the tmp yaml file, to take the backward
-    # compatbility restortion above into account.
-    # TODO: remove this after 2 minor releases, 0.10.0.
-    yaml_config = yaml_utils.read_yaml(tmp_yaml_path)
-    config_dict['cluster_name_on_cloud'] = yaml_config['cluster_name']
+    config_dict['cluster_name_on_cloud'] = cluster_name_on_cloud
 
     # Make sure to do this before we optimize file mounts. Optimization is
     # non-deterministic, but everything else before this point should be
@@ -3637,31 +3633,6 @@ def check_rsync_installed() -> None:
                 '  $ sudo apt install rsync') from None
 
 
-def check_stale_runtime_on_remote(returncode: int, stderr: str,
-                                  cluster_name: str) -> None:
-    """Raises RuntimeError if remote SkyPilot runtime needs to be updated.
-
-    We detect this by parsing certain backward-incompatible error messages from
-    `stderr`. Typically due to the local client version just got updated, and
-    the remote runtime is an older version.
-    """
-    pattern = re.compile(r'AttributeError: module \'sky\.(.*)\' has no '
-                         r'attribute \'(.*)\'')
-    if returncode != 0:
-        # TODO(zhwu): Backward compatibility for old SkyPilot runtime version on
-        # the remote cluster. Remove this after 0.10.0 is released.
-        attribute_error = re.findall(pattern, stderr)
-        if attribute_error or 'SkyPilot runtime is too old' in stderr:
-            with ux_utils.print_exception_no_traceback():
-                raise RuntimeError(
-                    f'{colorama.Fore.RED}SkyPilot runtime needs to be updated '
-                    f'on the remote cluster: {cluster_name}. To update, run '
-                    '(existing jobs will not be interrupted): '
-                    f'{colorama.Style.BRIGHT}sky start -f -y '
-                    f'{cluster_name}{colorama.Style.RESET_ALL}'
-                    f'\n--- Details ---\n{stderr.strip()}\n') from None
-
-
 def get_endpoints(cluster: str,
                   port: Optional[Union[int, str]] = None,
                   skip_status_check: bool = False) -> Dict[int, str]:

sky/backends/backend_utils.py

@@ -4431,10 +4431,6 @@ def _maybe_add_managed_job_code(job_submit_cmd: str) -> str:
                                                           job_submit_cmd,
                                                           stream_logs=False,
                                                           require_outputs=True)
-            # Happens when someone calls `sky exec` but remote is outdated for
-            # running a job. Necessitating calling `sky launch`.
-            backend_utils.check_stale_runtime_on_remote(returncode, stderr,
-                                                        handle.cluster_name)
             output = stdout + stderr
             if _is_message_too_long(returncode, output=output):
                 # If the job submit script is too long, we need to retry it
@@ -4502,10 +4498,6 @@ def _add_job(self, handle: CloudVmRayResourceHandle,
                 stream_logs=False,
                 require_outputs=True,
                 separate_stderr=True)
-            # Happens when someone calls `sky exec` but remote is outdated for
-            # adding a job. Necessitating calling `sky launch`.
-            backend_utils.check_stale_runtime_on_remote(returncode, stderr,
-                                                        handle.cluster_name)
             # TODO(zhwu): this sometimes will unexpectedly fail, we can add
             # retry for this, after we figure out the reason.
             subprocess_utils.handle_returncode(returncode, code,