WebSocket support

[fis-cz]

Hello,

I just tried the extension and it works well except a problem with websockets.

I am getting the following message:

HTTP/1.1 500 Internal Server Error
Date: Wed, 05 Mar 2025 11:53:22 GMT
Content-Length: 137
Content-Type: text/plain; charset=utf-8

Awesome TLS error: Get "...": http2: invalid Upgrade request header: ["websocket"]

I would say that the websocket is not supported at this time, true?

Are there any plans to support websockets?

Thank you.

[sleeyax]

Websocket is not supported.

See also: bogdanfinn/tls-client#95

Probably won't happen soon.

[sleeyax]

Looks like websocket support was added upstream about 3 weeks ago: bogdanfinn/tls-client#95 (comment). This would require thorough testing though. If anyone is interested in contributing I'd appreciate it!

[sleeyax]

Currently the initial handshake must be done over HTTP/1.1 and it seems like tls-client currently only supports this by enforcing the http client to use h1 for everything. Thus it's probably best to make websocket support a toggle in the extension settings.

https://github.com/bogdanfinn/tls-client/blob/e1e119e7300fd81ea1275e6041870a0a1a79f32d/websocket_options.go#L27-L37

Unless we create a second http client purely for the websocket connection 🤔 Need to consider the options.