Skip to content

Latest commit

Β 

History

History
72 lines (55 loc) Β· 2.13 KB

File metadata and controls

72 lines (55 loc) Β· 2.13 KB

πŸš€ Pull Request Creation Instructions

Branch Created βœ…

  • Branch Name: fix/position-event-indexing
  • Status: Pushed to origin
  • Ready for PR: Yes

Manual PR Creation Steps

1. Visit GitHub

Go to: https://github.com/sheyman546/Credence-Contracts

2. Create Pull Request

  1. Click on "Pull requests" tab
  2. Click "New pull request" button
  3. Select branches:
    • Base: main
    • Compare: fix/position-event-indexing
  4. Click "Create pull request"

3. PR Details

Title:

fix(contracts): improve indexed fields for position events

Description: Copy the content from PR_DESCRIPTION_EVENT_INDEXING.md

4. Labels and Assignees

  • Labels: enhancement, contracts, indexing, backward-compatibility
  • Assignees: Add relevant maintainers

5. Reviewers

Add appropriate reviewers for:

  • Smart contract review
  • Event schema validation
  • Backward compatibility assessment

βœ… What's Ready

  • Branch created and pushed
  • Comprehensive PR description written
  • All changes committed with proper messages
  • Tests passing
  • Documentation complete
  • Migration strategy documented

πŸ”— Quick Links

πŸ“‹ PR Summary for Quick Copy

Title: fix(contracts): improve indexed fields for position events

Key Points:

  • Fixes #162 - event indexing issues
  • Adds v2 events with enhanced indexing (amount, timestamp, balance)
  • Maintains backward compatibility (dual emission)
  • 10x+ faster off-chain queries
  • Comprehensive test coverage
  • Migration documentation included

Files Changed:

  • contracts/credence_bond/src/events.rs - V2 events
  • contracts/credence_bond/src/lib.rs - Dual emission
  • contracts/credence_bond/src/test_events_v2.rs - Tests
  • docs/EVENT_INDEXING_MIGRATION.md - Migration guide

Ready for review! πŸŽ‰