Skip to content

Remove deprecated wallet=noahwallet LNURL compatibility path #260

Description

@niteshbalusu11

Context

PR #259 replaced the Noah-specific wallet=noahwallet LNURL signal with the interoperable ark=<server_pubkey> capability parameter. The server temporarily accepts both forms so older Noah clients continue to work during migration.

Work

  • Confirm released Noah clients use ark=<server_pubkey> for Lightning-address route discovery.
  • Remove wallet from LnurlpRequestQuery.
  • Remove the wallet=noahwallet branch from negotiated_ark_address.
  • Remove or update legacy compatibility tests and comments.
  • Verify unsupported or missing ark parameters continue through the standard Lightning flow.

Acceptance criteria

  • The server no longer recognizes wallet=noahwallet.
  • Matching ark=<server_pubkey> requests still receive compatible Ark addresses.
  • Requests without a matching ark parameter receive normal LNURL responses without an Ark route.
  • Server formatting, checks, and focused LNURL tests pass.

Blocked until the client migration window following PR #259 is complete.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions