You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
feat: treat sbatch errors as job errors instead of workflow errors (#322)
fixes#320
When I do some very rudimentary testing it seems to work: when sbatch
fails, it is handled like a job error rather than a workflow error.
The argument for `report_job_error` needs to be a `SubmittedJobInfo`.
These jobs are technically never reported as submitted. I'm not sure if
that would cause some type of problem? Would this PR need some sort of
tests included?
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **Bug Fixes**
- Improved error handling during SLURM job submission to prevent
unnecessary interruptions when an error occurs, ensuring smoother
workflow execution.
- Fixed minor formatting issue related to job status checking for more
accurate time calculations.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
---------
Co-authored-by: Christian Meesters <[email protected]>
0 commit comments