Skip to content

Commit 2ce5e23

Browse files
committed
CR suggestions
1 parent d8f2269 commit 2ce5e23

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

e2e/global-setup.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ export default async function globalSetup() {
1111
const browser = await chromium.launch();
1212
const page = await browser.newPage();
1313

14-
await page.goto('http://localhost:4005/');
14+
await page.goto(
15+
process.env.PLAYWRIGHT_TEST_BASE_URL ?? 'http://localhost:4005/'
16+
);
1517

1618
await page.locator('#live-debugger-debug-button').click();
1719
const dbgAppPromise = page.waitForEvent('popup');

e2e/tests/node-inspector.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ test('callback traces have proper execution times displayed', async ({
7474

7575
await expect(traces).toHaveCount(2);
7676
await expect(traces.last().locator('span.text-warning-text')).toHaveText(
77-
/4\d\d ms/
77+
/^\s*4\d\d ms\s*$/
7878
);
7979

8080
await devApp
@@ -87,7 +87,7 @@ test('callback traces have proper execution times displayed', async ({
8787

8888
await expect(traces).toHaveCount(4);
8989
await expect(traces.nth(1).locator('span.text-error-text')).toHaveText(
90-
/1\.1\d s/
90+
/^\s*1\.1\d s\s*$/
9191
);
9292
});
9393

0 commit comments

Comments
 (0)