Langtour: restructure E2E badge assertions to wait for full execution

Author: mmietla

language-tour/src/utils/hooks/usePopcornEval.ts

@@ -11,10 +11,8 @@ export function usePopcornEval() {
     async (code: string, editorId: string) => {
       const stopLogCapture = startLogCapture();
 
-      const timeout = import.meta.env.VITE_PLAYWRIGHT_TEST ? 160_000 : 45_000;
-
       const result = await call(["eval_elixir", editorId, code, editorOrder], {
-        timeoutMs: timeout
+        timeoutMs: 40_000
       });
       const { stderr, stdout } = stopLogCapture();
 

language-tour/tests/language-tour.spec.ts

@@ -36,24 +36,19 @@ test.describe("Language Tour - All Topics", () => {
       const runButtons = page.locator("button").filter({ hasText: "Run Code" });
       await runButtons.last().click();
 
-      await expect(async () => {
-        const badges = page.locator("[data-testid='execution-state-badge']");
-        const count = await badges.count();
-        for (let i = 0; i < count; i++) {
-          const state = await badges.nth(i).getAttribute("data-state");
-          expect(state).not.toBe("running");
-          expect(state).not.toBe("queued");
-        }
-      }).toPass({ timeout: 30_000 });
-
       // TODO: support data-test-expect-failure attribute on code cells
       // to allow editors that are expected to fail
       const badges = page.locator("[data-testid='execution-state-badge']");
       const count = await badges.count();
       for (let i = 0; i < count; i++) {
-        await expect(badges.nth(i)).toHaveAttribute("data-state", "success", {
-          timeout: 180_000
-        });
+        await expect(async () => {
+          const state = await badges.nth(i).getAttribute("data-state");
+          expect(state).not.toBe("not_run");
+          expect(state).not.toBe("running");
+          expect(state).not.toBe("queued");
+        }).toPass({ timeout: 41_000 });
+
+        await expect(badges.nth(i)).toHaveAttribute("data-state", "success");
       }
 
       errorCollector.assertNoErrors();