fix: fixed frequencyBinCount prop

Author: Maciej Makowski

apps/common-app/src/examples/AudioVisualizer/AudioVisualizer.tsx

@@ -12,7 +12,7 @@ import FreqTimeChart from './FreqTimeChart';
 import { Container, Button } from '../../components';
 import { layout } from '../../styles';
 
-const FFT_SIZE = 2048;
+const FFT_SIZE = 256;
 const SMOOTHING_TIME_CONSTANT = 0.8;
 const MIN_DECIBELS = -140;
 const MAX_DECIBELS = 0;
@@ -82,6 +82,8 @@ const AudioVisualizer: React.FC = () => {
       analyserRef.current.minDecibels = MIN_DECIBELS;
       analyserRef.current.maxDecibels = MAX_DECIBELS;
 
+      console.log('analyser');
+
       analyserRef.current.connect(audioContextRef.current.destination);
     }
 

packages/react-native-audio-api/common/cpp/core/AnalyserNode.cpp

@@ -19,7 +19,7 @@ AnalyserNode::AnalyserNode(audioapi::BaseAudioContext *context)
       vWriteIndex_(0) {
   inputBuffer_ = std::make_unique<AudioArray>(MAX_FFT_SIZE * 2);
   fftFrame_ = std::make_unique<FFTFrame>(fftSize_);
-  magnitudeBuffer_ = std::make_unique<AudioArray>(DEFAULT_FFT_SIZE / 2);
+  magnitudeBuffer_ = std::make_unique<AudioArray>(fftSize_ / 2);
   isInitialized_ = true;
 }
 
@@ -50,6 +50,7 @@ void AnalyserNode::setFftSize(size_t fftSize) {
 
   fftSize_ = fftSize;
   fftFrame_ = std::make_unique<FFTFrame>(fftSize_);
+  magnitudeBuffer_ = std::make_unique<AudioArray>(fftSize_ / 2);
 }
 
 void AnalyserNode::setMinDecibels(double minDecibels) {

packages/react-native-audio-api/src/core/AnalyserNode.ts

@@ -1,24 +1,12 @@
 import { IndexSizeError } from '../errors';
 import { IAnalyserNode } from '../interfaces';
 import AudioNode from './AudioNode';
-import BaseAudioContext from './BaseAudioContext';
 
 export default class AnalyserNode extends AudioNode {
-  readonly frequencyBinCount: number;
   private static allowedFFTSize: number[] = [
     32, 64, 128, 256, 512, 1024, 2048, 4096, 8192, 16384, 32768,
   ];
 
-  constructor(context: BaseAudioContext, analyser: IAnalyserNode) {
-    super(context, analyser);
-
-    this.fftSize = analyser.fftSize;
-    this.frequencyBinCount = analyser.frequencyBinCount;
-    this.minDecibels = analyser.minDecibels;
-    this.maxDecibels = analyser.maxDecibels;
-    this.smoothingTimeConstant = analyser.smoothingTimeConstant;
-  }
-
   public get fftSize(): number {
     return (this.node as IAnalyserNode).fftSize;
   }
@@ -75,6 +63,10 @@ export default class AnalyserNode extends AudioNode {
     (this.node as IAnalyserNode).smoothingTimeConstant = value;
   }
 
+  public get frequencyBinCount(): number {
+    return (this.node as IAnalyserNode).frequencyBinCount;
+  }
+
   public getFloatFrequencyData(array: number[]): void {
     (this.node as IAnalyserNode).getFloatFrequencyData(array);
   }