diff --git a/cmake/common/clang-tidy.json b/cmake/common/clang-tidy.json index afa90899d..07548f498 100644 --- a/cmake/common/clang-tidy.json +++ b/cmake/common/clang-tidy.json @@ -1,5 +1,5 @@ { - "Checks": "-*, bugprone-*, -bugprone-easily-swappable-parameters,-bugprone-unchecked-optional-access, concurrency-*, cppcoreguidelines-avoid-const-or-ref-data-members, modernize-*, performance-*, portability-*", + "Checks": "-*, bugprone-*, -bugprone-easily-swappable-parameters,-bugprone-unchecked-optional-access, concurrency-*, cppcoreguidelines-rvalue-reference-param-not-moved,cppcoreguidelines-avoid-const-or-ref-data-members, modernize-*, performance-*, portability-*", "WarningsAsErrors": "*", "FormatStyle": "none", "UseColor": true diff --git a/src/core/json/include/sourcemeta/core/json_object.h b/src/core/json/include/sourcemeta/core/json_object.h index eeaa11cb3..8fcac7a3b 100644 --- a/src/core/json/include/sourcemeta/core/json_object.h +++ b/src/core/json/include/sourcemeta/core/json_object.h @@ -321,7 +321,7 @@ template class JSONObject { } } - this->data.push_back({key, value, key_hash}); + this->data.push_back({std::move(key), value, key_hash}); return key_hash; } diff --git a/src/core/json/json_value.cc b/src/core/json/json_value.cc index 76cd67d18..9179c145e 100644 --- a/src/core/json/json_value.cc +++ b/src/core/json/json_value.cc @@ -800,6 +800,7 @@ auto JSON::assign(const JSON::String &key, const JSON &value) -> void { this->data_object.emplace(key, value); } +// NOLINTNEXTLINE(cppcoreguidelines-rvalue-reference-param-not-moved) auto JSON::assign(const JSON::String &key, JSON &&value) -> void { assert(this->is_object()); this->data_object.emplace(key, value); diff --git a/src/core/jsonpointer/include/sourcemeta/core/jsonpointer_pointer.h b/src/core/jsonpointer/include/sourcemeta/core/jsonpointer_pointer.h index 1442d3e1f..afc6c0fda 100644 --- a/src/core/jsonpointer/include/sourcemeta/core/jsonpointer_pointer.h +++ b/src/core/jsonpointer/include/sourcemeta/core/jsonpointer_pointer.h @@ -257,7 +257,7 @@ template class GenericPointer { } this->reserve(this->data.size() + other.size()); - std::move(other.data.begin(), other.data.end(), + std::move(other.data.begin(), std::move(other).data.end(), std::back_inserter(this->data)); }