Hello,
I plan to make a couple of contributions to Deming and I'm making myself familiar with the codebase right now. One thing that confuses me is the naming of "measures" and "controls. It seems as if their names should be the other way round in the backend... if I am not mistaken? I read Issue #516 where someone asked about alice and bob. I suspect that in various places in the backend, it may have been named after the french terms initially and then kept like this, so there's a mix-up for historic reasons, is that right by any chance?
In the fontend:
- Controls = Maßnahmen = Mesures = URL "alice/"
- Measurements = Kontrollen = Contrôles = URL "bob/"
But for example, in routes/web.php it seems to be mixed up (from an English perspective):
/alice/* is handled by MeasureController/bob/* is handled by ControlControllerMeasureController queries database table controls and returns the resultsControlController queries database table measures and returns the results
Or in resources/views/control/show.blade.php:
@foreach($control->controls as $measure)
<a href="/alice/show/{{ $measure->id }}">{{ $measure->clause }}</a> - {{ $measure->name }}
@if(!$loop->last)
<br>
@endif
@endforeach
The database table names seem correct.
English is the odd one out among the languages. But since the backend code is primarily in English, the naming should be consistent. At least that's what I think.
Am I correct in my observations?
If so, do you plan to fix this? Would you accept a PR that fixes this?
Or maybe, in the mean time, this should be documented somewhere to avoid new developers.
Kind regards
Hello,
I plan to make a couple of contributions to Deming and I'm making myself familiar with the codebase right now. One thing that confuses me is the naming of "measures" and "controls. It seems as if their names should be the other way round in the backend... if I am not mistaken? I read Issue #516 where someone asked about alice and bob. I suspect that in various places in the backend, it may have been named after the french terms initially and then kept like this, so there's a mix-up for historic reasons, is that right by any chance?
In the fontend:
But for example, in
routes/web.phpit seems to be mixed up (from an English perspective):/alice/*is handled byMeasureController/bob/*is handled byControlControllerMeasureControllerqueries database tablecontrolsand returns the resultsControlControllerqueries database tablemeasuresand returns the resultsOr in
resources/views/control/show.blade.php:The database table names seem correct.
English is the odd one out among the languages. But since the backend code is primarily in English, the naming should be consistent. At least that's what I think.
Am I correct in my observations?
If so, do you plan to fix this? Would you accept a PR that fixes this?
Or maybe, in the mean time, this should be documented somewhere to avoid new developers.
Kind regards