You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Add feature / balance request triaging for Github Issues (#576)
This PR includes a change to the Triaging Procedure to give more freedom
for Triagers to close feature and balance requests in Github Issues.
---------
Co-authored-by: Rem <Remfexxel@pm.me>
Copy file name to clipboardExpand all lines: src/en/wizden-staff/maintainer/triage-procedure.md
+14-6Lines changed: 14 additions & 6 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -73,16 +73,24 @@ Non-Maintainer Triagers **must not** tag a PR as `S: Derelict`. This tag is to b
73
73
74
74
### Closing Issues
75
75
76
-
Any Triager **may** close Issues if they are no-longer relevant.
76
+
#### Bug Reports
77
+
78
+
Any triager **may** close bug report Issues if they are no longer relevant.
77
79
78
80
When closing an issue, triage best practice involves adding a comment that contains one or more of the following:
79
81
* a link to the PR that resolved it,
80
-
* an in-game screenshot or video showing the issue is no longer relevant,
82
+
* an in-game screenshot or video showing the issue is no longer relevant (if applicable),
81
83
* a note why the issue should not be addressed due to being an intended mechanic (in this last case, mark the Issue with `Issue: Intended Feature`).
82
84
85
+
#### Feature / Balance Requests
86
+
87
+
GitHub Issues is not intended to be an idea-guys forum. Any triager **should** close feature/balance request issues that do not cite conceptual approval from a maintainer. It is fine if the approval is included in the issue description; the maintainer doesn't need to comment on the issue itself. If an issue cites approval, triagers **should** tag the issue with the `S: Conceptual Approval` label.
88
+
89
+
This applies to feature/balance requests created by maintainers, which **must** have conceptual approval from another maintainer. If a maintainer-made request lacks approval, please request it before closing the issue.
90
+
83
91
### Never Closing PRs
84
92
85
-
Non-Maintainer Triagers**must never** close Pull Requests. This is **always** a Maintainer responsibility.
93
+
Non-maintainer triagers**must never** close pull requests. This is **always** a maintainer's responsibility.
86
94
87
95
## Other SS14 Github Label Categories
88
96
@@ -108,10 +116,10 @@ Some labels **should not** be used/removed by non-Maintainer Triagers, as they a
108
116
| All Size tags | Applied automatically.*|
109
117
| S: Approved | Only Maintainers can approve items. Applied automatically. |
110
118
| S: Awaiting Changes | Applied automatically. |
111
-
| S: Conceptual Approval | Can only be applied by a Maintainer, following Review Procedure. |
112
-
| S: Undergoing Maintainer Discussion | Maintainer Discussions are at Maintainers' discretion. |
119
+
| S: Conceptual Approval | Can only be applied by a maintainer on PRs, following Review Procedure. Exception for [Issues](#feature--balance-requests).|
120
+
| S: Undergoing Maintainer Discussion | Maintainer Discussions are at the maintainers' discretion. |
113
121
| S: Art Approval | Can only be applied by an Art Lead following their approval. If the Art Lead has forgotten to apply it, Triagers may apply this label. |
114
-
| S: Concern | Only applied by a Maintainer with concern about a particular PR. |
122
+
| S: Concern | Only applied by a maintainer with concern about a particular PR. |
115
123
| S: DO NOT MERGE | Only applied by a Maintainer to PRs when that must be blocked from merging due to integration problems, extreme controversy, or other good reasons. |
116
124
117
125
\* May still be applied in certain cases, if the automatic labelling is not working/not implemented.
0 commit comments