Skip to content

Commit 3922e41

Browse files
Add feature / balance request triaging for Github Issues (#576)
This PR includes a change to the Triaging Procedure to give more freedom for Triagers to close feature and balance requests in Github Issues. --------- Co-authored-by: Rem <Remfexxel@pm.me>
1 parent 6eb0c76 commit 3922e41

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

src/en/wizden-staff/maintainer/triage-procedure.md

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,24 @@ Non-Maintainer Triagers **must not** tag a PR as `S: Derelict`. This tag is to b
7373

7474
### Closing Issues
7575

76-
Any Triager **may** close Issues if they are no-longer relevant.
76+
#### Bug Reports
77+
78+
Any triager **may** close bug report Issues if they are no longer relevant.
7779

7880
When closing an issue, triage best practice involves adding a comment that contains one or more of the following:
7981
* a link to the PR that resolved it,
80-
* an in-game screenshot or video showing the issue is no longer relevant,
82+
* an in-game screenshot or video showing the issue is no longer relevant (if applicable),
8183
* a note why the issue should not be addressed due to being an intended mechanic (in this last case, mark the Issue with `Issue: Intended Feature`).
8284

85+
#### Feature / Balance Requests
86+
87+
GitHub Issues is not intended to be an idea-guys forum. Any triager **should** close feature/balance request issues that do not cite conceptual approval from a maintainer. It is fine if the approval is included in the issue description; the maintainer doesn't need to comment on the issue itself. If an issue cites approval, triagers **should** tag the issue with the `S: Conceptual Approval` label.
88+
89+
This applies to feature/balance requests created by maintainers, which **must** have conceptual approval from another maintainer. If a maintainer-made request lacks approval, please request it before closing the issue.
90+
8391
### Never Closing PRs
8492

85-
Non-Maintainer Triagers **must never** close Pull Requests. This is **always** a Maintainer responsibility.
93+
Non-maintainer triagers **must never** close pull requests. This is **always** a maintainer's responsibility.
8694

8795
## Other SS14 Github Label Categories
8896

@@ -108,10 +116,10 @@ Some labels **should not** be used/removed by non-Maintainer Triagers, as they a
108116
| All Size tags | Applied automatically.* |
109117
| S: Approved | Only Maintainers can approve items. Applied automatically. |
110118
| S: Awaiting Changes | Applied automatically. |
111-
| S: Conceptual Approval | Can only be applied by a Maintainer, following Review Procedure. |
112-
| S: Undergoing Maintainer Discussion | Maintainer Discussions are at Maintainers' discretion. |
119+
| S: Conceptual Approval | Can only be applied by a maintainer on PRs, following Review Procedure. Exception for [Issues](#feature--balance-requests). |
120+
| S: Undergoing Maintainer Discussion | Maintainer Discussions are at the maintainers' discretion. |
113121
| S: Art Approval | Can only be applied by an Art Lead following their approval. If the Art Lead has forgotten to apply it, Triagers may apply this label. |
114-
| S: Concern | Only applied by a Maintainer with concern about a particular PR. |
122+
| S: Concern | Only applied by a maintainer with concern about a particular PR. |
115123
| S: DO NOT MERGE | Only applied by a Maintainer to PRs when that must be blocked from merging due to integration problems, extreme controversy, or other good reasons. |
116124

117125
\* May still be applied in certain cases, if the automatic labelling is not working/not implemented.

0 commit comments

Comments
 (0)