Skip to content

Commit abf6d48

Browse files
clarify approval circumstances
1 parent 2c4b2e0 commit abf6d48

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

src/en/wizden-staff/maintainer/review-procedure.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,15 @@ If the pull request does not line up with any category listed here, defer to two
6363

6464
- **One Approval:**
6565
- Light code cleanup
66-
- This can be something like cleaning up errors in a few files, fixing formatting, or documenting a large group of files.
66+
- Cleaning up errors in a few files, fixing formatting, or documenting a large group of files.
6767
- Bugfixes small in scope
6868
- Small bugfixes that don't touch major hotpaths, or critical code paths (like Atmospherics, Reagents, Physics, Movement, HTN, etc.).
6969
- Player-facing changes small in impact
7070
- Guidebook changes or renames, description changes or renames.
71-
- Small content additions that have little balancing impact, ex. new logic gates.
71+
- Locale changes.
72+
- Item additions to inventory fills.
73+
- Container size tweaks.
74+
- Loadout item tweaks, additions, or removals.
7275
- **Two Approvals:**
7376
- Heavy code cleanup
7477
- Large cleanup of warnings across the codebase or the refactoring of an entire system.
@@ -79,7 +82,8 @@ If the pull request does not line up with any category listed here, defer to two
7982
- Performance improvements
8083
- These should usually come with a custom BenchmarkDotNet benchmark to prove that the PR has a meaningful effect on performance.
8184
- Player-facing changes large in impact.
82-
- Major features, new content.
85+
- Major additions like new antagonists, medical systems, atmospherics processing states, etc.
86+
- Wide balancing revamps (ex. the rebalancing of an entire antagonists' store).
8387

8488
#### Exceptions
8589
There are some exceptions to the one-approval or two-approval system. They are listed below.

0 commit comments

Comments
 (0)