Skip to content

Commit d425ec5

Browse files
committed
docs(instructions): add KenPom CSS selector fragility to Common Pitfalls
- Add note about KenPom HTML structure changes (table#player-table, div.refline selectors) to both copilot-instructions.md and CLAUDE.md
1 parent 33fd143 commit d425ec5

2 files changed

Lines changed: 7 additions & 2 deletions

File tree

.github/copilot-instructions.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
<!-- START doctoc generated TOC please keep comment here to allow auto update -->
22
<!-- DON'T EDIT THIS SECTION, INSTEAD RE-RUN doctoc TO UPDATE -->
33

4-
**Table of Contents** _generated with [DocToc](https://github.com/thlorenz/doctoc)_
54

65
- [hoopR Copilot Instructions](#hoopr-copilot-instructions)
76
- [Project Context](#project-context)
7+
- [Repository Workflow](#repository-workflow)
88
- [Code Style](#code-style)
9-
- [Function Naming](#function-naming)
109
- [HTTP Layer](#http-layer)
1110
- [Messaging Layer](#messaging-layer)
11+
- [Function Naming](#function-naming)
1212
- [Roxygen Documentation](#roxygen-documentation)
1313
- [Testing](#testing)
1414
- [Environment Variables](#environment-variables)
15+
- [CI Secrets](#ci-secrets)
1516
- [Conventional Commits](#conventional-commits)
1617
- [V3 API Notes](#v3-api-notes)
1718
- [Common Pitfalls](#common-pitfalls)
@@ -153,4 +154,5 @@ Types: `feat`, `fix`, `docs`, `test`, `refactor`, `chore`, `style`, `perf`, `ci`
153154
- IST Standings has dynamic game columns -- use `expect_true(all(core_cols %in% colnames()))`.
154155
- NBAGL legacy schemas are no longer stable references for tests. Prefer validating core columns from current API payloads and handle named-list returns explicitly in tests.
155156
- Local editor/worktree artifacts (e.g., `.vscode`, `.claude`, temp logs) can cause `R CMD check` notes/warnings if included in source checks.
157+
- KenPom HTML structure changes periodically -- CSS selectors for tables (`table#player-table`), referee links (`div.refline`), and navigation elements are fragile and may need updating.
156158
- Never edit `NAMESPACE` or `man/` files by hand; regenerate with `devtools::document()`.

CLAUDE.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
- [CLAUDE.md -- hoopR Development Guide](#claudemd----hoopr-development-guide)
66
- [Package Overview](#package-overview)
7+
- [Branching & PR Workflow](#branching--pr-workflow)
78
- [Build & Development Commands](#build--development-commands)
89
- [Project Structure](#project-structure)
910
- [Key Coding Conventions](#key-coding-conventions)
@@ -17,6 +18,7 @@
1718
- [Testing](#testing)
1819
- [Test Pattern](#test-pattern)
1920
- [Environment Variables for Tests](#environment-variables-for-tests)
21+
- [CI Secrets](#ci-secrets)
2022
- [Rate Limiting](#rate-limiting)
2123
- [NAMESPACE](#namespace)
2224
- [Commit Convention](#commit-convention)
@@ -343,4 +345,5 @@ Split unrelated work into separate commits for reviewability.
343345
- `.v3_to_v2_format()` uses row-level loops for player resolution -- performance-sensitive for large PBP datasets. The `%||%` operator from rlang is used for null-safe named vector lookups in event type maps.
344346
- `.players_on_court_v3()` depends on `nba_gamerotation()` returning `IN_TIME_REAL`/`OUT_TIME_REAL` in tenths of a second -- ensure time unit consistency when modifying.
345347
- Local dev artifacts (for example `.vscode`, `.claude`, ad-hoc logs) can surface as `R CMD check` notes/warnings if not excluded from build inputs.
348+
- KenPom HTML structure changes periodically -- CSS selectors for tables (`table#player-table`), referee links (`div.refline`), and navigation elements are fragile and may need updating.
346349
- Never hand-edit `NAMESPACE` or files under `man/`; regenerate with `devtools::document()`.

0 commit comments

Comments
 (0)