bug: commonallplayers not working

[skdeshpande91]

Function and Parameters
Which hoopR function(s) are affected? Include the exact parameters used.

nba_commonallplayers()

Describe the bug

Function does not work: I anticipate there's an issue with the `request_with_proxy' calls here

Reprex (Reproducible Example)
Please include a minimal reproducible example using reprex::reprex():

test <- nba_commonallplayers()

Expected behavior
Expected a named list containing a data frame CommonAllPlayers.

Error message / output

Invalid arguments or common all players data for 2025-26 available!

This error seems to be thrown by this part of the source code

Session Info
Paste the output of sessionInfo():

R version 4.5.2 (2025-10-31)
Platform: aarch64-apple-darwin20
Running under: macOS Sequoia 15.7.3

Matrix products: default
BLAS:   /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 
LAPACK: /Library/Frameworks/R.framework/Versions/4.5-arm64/Resources/lib/libRlapack.dylib;  LAPACK version 3.12.1

locale:
[1] en_US.UTF-8/en_US.UTF-8/en_US.UTF-8/C/en_US.UTF-8/en_US.UTF-8

time zone: America/Chicago
tzcode source: internal

attached base packages:
[1] stats     graphics  grDevices utils     datasets 
[6] methods   base     

other attached packages:
[1] hoopR_3.0.0

loaded via a namespace (and not attached):
 [1] crayon_1.5.3          vctrs_0.7.2          
 [3] httr_1.4.8            cli_3.6.5            
 [5] rlang_1.1.7           stringi_1.8.7        
 [7] otel_0.2.0            purrr_1.2.1          
 [9] generics_0.1.4        jsonlite_2.0.0       
[11] data.table_1.18.0     RcppParallel_5.1.11-1
[13] glue_1.8.0            janitor_2.2.1        
[15] rappdirs_0.3.3        snakecase_0.11.1     
[17] tibble_3.3.1          lifecycle_1.0.5      
[19] httr2_1.2.2           stringr_1.6.0        
[21] compiler_4.5.2        rvest_1.0.5          
[23] dplyr_1.2.0           timechange_0.4.0     
[25] Rcpp_1.1.1            pkgconfig_2.0.3      
[27] tidyr_1.3.2           rstudioapi_0.17.1    
[29] R6_2.6.1              tidyselect_1.2.1     
[31] curl_7.0.0            pillar_1.11.1        
[33] magrittr_2.0.4        tools_4.5.2          
[35] lubridate_1.9.5       xml2_1.5.2 

Additional context

• hoopR version: 3.0.0
• R version: 4.5.2
• OS: macOS Sequoia 15.7.3

[saiemgilani]

Are you still receiving this error? I'm on the same version of R and hoopR (but on Windows) and I get:

hoopR::nba_commonallplayers()
#> $CommonAllPlayers
#> # A tibble: 5,123 × 16
#>    PERSON_ID DISPLAY_LAST_COMMA_FIRST DISPLAY_FIRST_LAST  ROSTERSTATUS FROM_YEAR
#>    <chr>     <chr>                    <chr>               <chr>        <chr>    
#>  1 76001     Abdelnaby, Alaa          Alaa Abdelnaby      0            1990     
#>  2 76002     Abdul-Aziz, Zaid         Zaid Abdul-Aziz     0            1968     
#>  3 76003     Abdul-Jabbar, Kareem     Kareem Abdul-Jabbar 0            1969     
#>  4 51        Abdul-Rauf, Mahmoud      Mahmoud Abdul-Rauf  0            1990     
#>  5 1505      Abdul-Wahad, Tariq       Tariq Abdul-Wahad   0            1997     
#>  6 949       Abdur-Rahim, Shareef     Shareef Abdur-Rahim 0            1996     
#>  7 76005     Abernethy, Tom           Tom Abernethy       0            1976     
#>  8 76006     Able, Forest             Forest Able         0            1956     
#>  9 76007     Abramovic, John          John Abramovic      0            1946     
#> 10 203518    Abrines, Alex            Alex Abrines        0            2016     
#> # ℹ 5,113 more rows
#> # ℹ 11 more variables: TO_YEAR <chr>, PLAYERCODE <chr>, PLAYER_SLUG <chr>,
#> #   TEAM_ID <chr>, TEAM_CITY <chr>, TEAM_NAME <chr>, TEAM_ABBREVIATION <chr>,
#> #   TEAM_CODE <chr>, TEAM_SLUG <chr>, GAMES_PLAYED_FLAG <chr>,
#> #   OTHERLEAGUE_EXPERIENCE_CH <chr>

^{Created on 2026-03-31 with reprex v2.1.1}

Try re-installing for good measure, refresh your session, retry and let me know the outcome. I don't have a good reason for why this is happening and may need to investigate. Thank you for your detailed bug report, very helpful.

[critmcdonald]

FWIW, I'm also on a Mac and I'm getting errors on every nba_ function I've tried. I've reinstalled and refreshed my R session. Same version of R. I'm on MacOS Sequoia 15.7.5 (24G624).

I have a student on Windows who is using the same code with no problem.

For nba_teams() I got:

2026-04-10 07:11:44.291844: Invalid arguments or no league standings v3 data available for 2025-26!
2026-04-10 07:12:44.334096: Invalid arguments or no league game log data for 2025-26 available!
2026-04-10 07:12:44.334813: Invalid arguments or no team details data available!

and

function (...) 
{
    tryCatch(expr = {
        standings <- nba_leaguestandingsv3(season = year_to_season(most_recent_nba_season() - 
            1), ...) %>% purrr::pluck("Standings")
        league_gamelog <- nba_leaguegamelog(league_id = "00", 
            season = year_to_season(most_recent_nba_season() - 
                1), ...) %>% purrr::pluck("LeagueGameLog")
        if (nrow(league_gamelog) == 0) {
            league_gamelog <- nba_leaguegamelog(league_id = "00", 
                season = year_to_season(most_recent_nba_season() - 
                  2), ...) %>% purrr::pluck("LeagueGameLog")
        }
        league_gamelog <- league_gamelog %>% dplyr::rename(dplyr::any_of(c(team_name_full = "TEAM_NAME"))) %>% 
            dplyr::select(dplyr::any_of(c("TEAM_ID", "TEAM_ABBREVIATION", 
                "team_name_full"))) %>% dplyr::distinct()
        standings <- standings %>% dplyr::left_join(league_gamelog, 
            by = c(TeamID = "TEAM_ID"))
        nba_teams <- standings %>% dplyr::select(dplyr::any_of(c("LeagueID", 
            "SeasonID", "TeamID", "TeamCity", "TeamName", "TeamSlug", 
            "Conference", "Division", "TEAM_ABBREVIATION", "team_name_full"))) %>% 
            dplyr::mutate(Season = paste0("", year_to_season(most_recent_nba_season() - 
                1))) %>% dplyr::arrange(.data$team_name_full)
        espn_nba_teams <- espn_nba_teams() %>% dplyr::rename(dplyr::any_of(c(espn_team_id = "team_id")))
        nba_teams <- nba_teams %>% dplyr::left_join(espn_nba_teams, 
            by = c(TeamName = "short_name"))
        nba_teams <- nba_teams %>% dplyr::mutate(espn_team_id = as.integer(.data$espn_team_id), 
            nba_logo_svg = paste0("https://cdn.nba.com/logos/nba/", 
                .data$TeamID, "/primary/L/logo.svg")) %>% janitor::clean_names()
    }, error = function(e) {
        message(glue::glue("{Sys.time()}: Invalid arguments or no team details data available!"))
    }, warning = function(w) {
    }, finally = {
    })
    return(nba_teams)
}
<bytecode: 0x1072ce500>
<environment: namespace:hoopR>