Improve Snowflake ALTER TABLE/ALTER COLUMN syntax and tests

Author: nene

src/languages/snowflake/snowflake.formatter.ts

@@ -61,24 +61,23 @@ const reservedCommands = expandPhrases([
   'ALTER TABLE [IF EXISTS]',
   'RENAME TO',
   'SWAP WITH',
-  '{SET | UNSET} [TAG | DATA_RETENTION_TIME_IN_DAYS | MAX_DATA_EXTENSION_TIME_IN_DAYS | CHANGE_TRACKING | DEFAULT_DDL_COLLATION | COMMENT]',
-  '{ADD | DROP} ROW ACCESS POLICY',
-  'DROP ALL ROW ACCESS POLICIES',
   '[SUSPEND | RESUME] RECLUSTER',
   'DROP CLUSTERING KEY',
   'ADD [COLUMN]',
   'RENAME COLUMN',
   '{ALTER | MODIFY} [COLUMN]',
   'DROP [COLUMN]',
+  '{ADD | ALTER | MODIFY | DROP} [CONSTRAINT]',
+  'RENAME CONSTRAINT',
+  '{ADD | DROP} SEARCH OPTIMIZATION',
+  '{SET | UNSET} [TAG]',
+  '{ADD | DROP} ROW ACCESS POLICY',
+  'DROP ALL ROW ACCESS POLICIES',
   '{SET | DROP} DEFAULT', // for alter column
-  'SET NOT NULL', // for alter column
-  'DROP NOT NULL', // for alter column
+  '{SET | DROP} NOT NULL', // for alter column
   '[SET DATA] TYPE', // for alter column
   '[UNSET] COMMENT', // for alter column
-  '{SET | UNSET} {MASKING POLICY | TAG}', // for alter column
-  '[FOREIGN KEY] REFERENCES', // for alter column
-  '{ADD | RENAME | ALTER | MODIFY | DROP} CONSTRAINT', // for alter column
-  '{ADD | DROP} SEARCH OPTIMIZATION', // for alter column
+  '{SET | UNSET} MASKING POLICY', // for alter column
 
   // other
   // https://docs.snowflake.com/en/sql-reference/sql-all.html

test/snowflake.test.ts

@@ -89,4 +89,94 @@ describe('SnowflakeFormatter', () => {
         $$foo$$ $$bar$$
     `);
   });
+
+  it('formats ALTER TABLE ... ALTER COLUMN', () => {
+    expect(
+      format(
+        `ALTER TABLE t ALTER COLUMN foo SET DATA TYPE VARCHAR;
+         ALTER TABLE t ALTER COLUMN foo SET DEFAULT 5;
+         ALTER TABLE t ALTER COLUMN foo DROP DEFAULT;
+         ALTER TABLE t ALTER COLUMN foo SET NOT NULL;
+         ALTER TABLE t ALTER COLUMN foo DROP NOT NULL;
+         ALTER TABLE t ALTER COLUMN foo COMMENT 'blah';
+         ALTER TABLE t ALTER COLUMN foo UNSET COMMENT;
+         ALTER TABLE t ALTER COLUMN foo SET MASKING POLICY polis;
+         ALTER TABLE t ALTER COLUMN foo UNSET MASKING POLICY;
+         ALTER TABLE t ALTER COLUMN foo SET TAG tname = 10;
+         ALTER TABLE t ALTER COLUMN foo UNSET TAG tname;`
+      )
+    ).toBe(dedent`
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      SET DATA TYPE
+        VARCHAR;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      SET DEFAULT
+        5;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      DROP DEFAULT;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      SET NOT NULL;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      DROP NOT NULL;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      COMMENT
+        'blah';
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      UNSET COMMENT;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      SET MASKING POLICY
+        polis;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      UNSET MASKING POLICY;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      SET TAG
+        tname = 10;
+
+      ALTER TABLE
+        t
+      ALTER COLUMN
+        foo
+      UNSET TAG
+        tname;
+    `);
+  });
 });