Add support for WINDOW clause in multiple dialects

Author: nene

src/languages/bigquery.formatter.ts

@@ -696,6 +696,7 @@ const reservedCommands = [
   'ORDER BY',
   'QUALIFY',
   'WINDOW',
+  'PARTITION BY',
   'LIMIT',
   'OFFSET',
   'WITH',

src/languages/hive.formatter.ts

@@ -572,6 +572,8 @@ const reservedCommands = [
   'VALUES',
   'WHERE',
   'WITH',
+  'WINDOW',
+  'PARTITION BY',
 
   // newline keywords
   'STORED AS',

src/languages/mysql.formatter.ts

@@ -1274,6 +1274,8 @@ const reservedCommands = [
   'OFFSET',
   'ORDER BY',
   'WHERE',
+  'WINDOW',
+  'PARTITION BY',
 ];
 
 const reservedBinaryCommands = [

src/languages/n1ql.formatter.ts

@@ -472,6 +472,8 @@ const reservedCommands = [
   'VALUES',
   'WHERE',
   'WITH',
+  'WINDOW',
+  'PARTITION BY',
 ];
 
 const reservedBinaryCommands = [

src/languages/postgresql.formatter.ts

@@ -1580,6 +1580,8 @@ const reservedCommands = [
   'ORDER BY',
   'WHERE',
   'WITH',
+  'WINDOW',
+  'PARTITION BY',
 ];
 
 const reservedBinaryCommands = [

src/languages/sql.formatter.ts

@@ -347,6 +347,8 @@ const reservedCommands = [
   'VALUES',
   'WHERE',
   'WITH',
+  'WINDOW',
+  'PARTITION BY',
 ];
 
 const reservedBinaryCommands = [

src/languages/sqlite.formatter.ts

@@ -239,6 +239,8 @@ const reservedCommands = [
   'VALUES',
   'WHERE',
   'WITH',
+  'WINDOW',
+  'PARTITION BY',
 ];
 
 const reservedBinaryCommands = [

src/languages/tsql.formatter.ts

@@ -1189,6 +1189,8 @@ const reservedCommands = [
   'VALUES',
   'WHERE',
   'WITH',
+  'WINDOW',
+  'PARTITION BY',
 ];
 
 const reservedBinaryCommands = [

test/bigquery.test.ts

@@ -15,6 +15,7 @@ import supportsDeleteFrom from './features/deleteFrom';
 import supportsComments from './features/comments';
 import supportsIdentifiers from './features/identifiers';
 import supportsParams from './options/param';
+import supportsWindow from './features/window';
 
 describe('BigQueryFormatter', () => {
   const language = 'bigquery';
@@ -32,6 +33,7 @@ describe('BigQueryFormatter', () => {
   supportsJoin(format, { without: ['NATURAL JOIN'] });
   supportsOperators(format, BigQueryFormatter.operators);
   supportsParams(format, { positional: true, named: ['@'], quoted: ['@``'] });
+  supportsWindow(format);
 
   // Note: BigQuery supports single dashes inside identifiers, so my-ident would be
   // detected as identifier, while other SQL dialects would detect it as

test/features/window.ts

@@ -0,0 +1,47 @@
+import dedent from 'dedent-js';
+
+import { FormatFn } from 'src/sqlFormatter';
+
+export default function supportsWindow(format: FormatFn) {
+  it('formats WINDOW clause at top level', () => {
+    const result = format(
+      'SELECT *, LAG(value) OVER wnd AS next_value FROM tbl WINDOW wnd AS (PARTITION BY id ORDER BY time);'
+    );
+    expect(result).toBe(dedent`
+      SELECT
+        *,
+        LAG(value) OVER wnd AS next_value
+      FROM
+        tbl
+      WINDOW
+        wnd AS (
+          PARTITION BY
+            id
+          ORDER BY
+            time
+        );
+    `);
+  });
+
+  it('formats multiple WINDOW specifications', () => {
+    const result = format(
+      'SELECT * FROM table1 WINDOW w1 AS (PARTITION BY col1), w2 AS (PARTITION BY col1, col2);'
+    );
+    expect(result).toBe(dedent`
+      SELECT
+        *
+      FROM
+        table1
+      WINDOW
+        w1 AS (
+          PARTITION BY
+            col1
+        ),
+        w2 AS (
+          PARTITION BY
+            col1,
+            col2
+        );
+    `);
+  });
+}