Skip to content

Commit b5d4f4b

Browse files
cursoragentlovasoa
andcommitted
Remove redundant Method::GET from OIDC test requests
Co-authored-by: contact <[email protected]>
1 parent 435d523 commit b5d4f4b

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

src/webserver/oidc.rs

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -703,7 +703,7 @@ fn validate_redirect_url(url: &str) -> String {
703703
#[cfg(test)]
704704
mod tests {
705705
use super::{validate_redirect_url, AuthUrlParams, OidcLoginState};
706-
use actix_web::{http::Method, test};
706+
use actix_web::test;
707707
use openidconnect::{CsrfToken, Nonce};
708708

709709
#[test]
@@ -716,9 +716,7 @@ mod tests {
716716

717717
#[test]
718718
async fn test_build_safe_redirect_url_without_query_params() {
719-
let req = test::TestRequest::with_uri("/page.sql")
720-
.method(Method::GET)
721-
.to_srv_request();
719+
let req = test::TestRequest::with_uri("/page.sql").to_srv_request();
722720

723721
let result = OidcLoginState::build_safe_redirect_url(&req);
724722
assert_eq!(result, "/page.sql");
@@ -727,7 +725,6 @@ mod tests {
727725
#[test]
728726
async fn test_build_safe_redirect_url_with_special_characters() {
729727
let req = test::TestRequest::with_uri("/page.sql?param=hello%20world&special=%26%3D")
730-
.method(Method::GET)
731728
.to_srv_request();
732729

733730
let result = OidcLoginState::build_safe_redirect_url(&req);
@@ -737,9 +734,7 @@ mod tests {
737734
#[test]
738735
async fn test_build_safe_redirect_url_handles_root_path() {
739736
// TestRequest with invalid relative path defaults to "/"
740-
let req = test::TestRequest::with_uri("page.sql")
741-
.method(Method::GET)
742-
.to_srv_request();
737+
let req = test::TestRequest::with_uri("page.sql").to_srv_request();
743738

744739
let result = OidcLoginState::build_safe_redirect_url(&req);
745740
// TestRequest normalizes invalid URI to root path
@@ -773,7 +768,6 @@ mod tests {
773768
#[test]
774769
async fn test_oidc_login_state_preserves_query_parameters() {
775770
let req = test::TestRequest::with_uri("/dashboard.sql?user_id=123&filter=active")
776-
.method(Method::GET)
777771
.to_srv_request();
778772

779773
let auth_params = AuthUrlParams {

0 commit comments

Comments
 (0)