fix: edit tool error after undo #4923
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents unnecessary write -> error "modified externaly" -> read -> write cycles when editing files after undo. - Update FileTime for reverted files in `revert()` and `unrevert()` so the edit tool sees them as freshly read rather than externally modified *Restoring the old read time would be more "semantically correct" but adds complexity without functional benefit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents unnecessary read/write cycles when editing files after undo / redo.
From
edit -> error "modified externally" -> read -> edit(extra read and edit in context + extra time) to justedit.revert()andunrevert()so the edit tool sees them as freshly read rather than externally modified*Restoring the old read time would be more semantically correct but adds complexity without functional benefit.