fuzz: harden CAT-3-8 with StaleBlockNumber guard and ebRoots verification, tighten CAT-2-8 balance assertion

Author: venimir-ssv

test/ssv-fuzz-engine/eb-oracle-quorum.fuzz.ts

@@ -129,7 +129,7 @@ describe("Fuzz: Oracle quorum — partial votes, failed quorum, re-voting (CAT-3
           },
 
           {
-            name: "phase2-revote-prevention",
+            name: "phase2-duplicate-vote-prevention",
             async fn(ctx) {
               const { allOracles, shuffledIndices, rootAEB, rootABlockNum, cluster } = ctx.state;
               const clusterId = computeClusterId(cluster.owner.address, cluster.operatorIds);
@@ -139,7 +139,7 @@ describe("Fuzz: Oracle quorum — partial votes, failed quorum, re-voting (CAT-3
                 ctx.network.connect(allOracles[shuffledIndices[0]]).commitRoot(rootA, rootABlockNum),
               ).to.be.revertedWithCustomError(ctx.network, Errors.ALREADY_VOTED);
 
-              ctx.state.phase = "revote-blocked";
+              ctx.state.phase = "duplicate-blocked";
             },
           },
 
@@ -155,6 +155,9 @@ describe("Fuzz: Oracle quorum — partial votes, failed quorum, re-voting (CAT-3
               expect(hasEvent(ctx.network, receipt3, Events.WEIGHTED_ROOT_PROPOSED)).to.equal(true);
               expect(hasEvent(ctx.network, receipt3, Events.ROOT_COMMITTED)).to.equal(true);
 
+              const storedRoot = await ctx.views.getCommittedRoot(rootABlockNum);
+              expect(storedRoot).to.equal(rootA);
+
               const tx = await ctx.network.updateClusterBalance(
                 rootABlockNum,
                 cluster.owner.address,
@@ -183,7 +186,22 @@ describe("Fuzz: Oracle quorum — partial votes, failed quorum, re-voting (CAT-3
           },
 
           {
-            name: "phase4-competing-roots",
+            name: "phase4-post-commit-stale-retry",
+            async fn(ctx) {
+              const { allOracles, shuffledIndices, rootAEB, rootABlockNum, cluster } = ctx.state;
+              const clusterId = computeClusterId(cluster.owner.address, cluster.operatorIds);
+              const rootA = computeEBRoot(clusterId, rootAEB);
+
+              await expect(
+                ctx.network.connect(allOracles[shuffledIndices[0]]).commitRoot(rootA, rootABlockNum),
+              ).to.be.revertedWithCustomError(ctx.network, Errors.STALE_BLOCK_NUMBER);
+
+              ctx.state.phase = "stale-blocked";
+            },
+          },
+
+          {
+            name: "phase5-competing-roots",
             async fn(ctx) {
               const { cluster, allOracles, shuffledIndices, rootBEB, rootCEB } = ctx.state;
               const clusterId = computeClusterId(cluster.owner.address, cluster.operatorIds);
@@ -227,6 +245,9 @@ describe("Fuzz: Oracle quorum — partial votes, failed quorum, re-voting (CAT-3
               const receipt = await tx.wait();
               cluster.cluster = parseClusterFromEvent(ctx.network, receipt, Events.CLUSTER_BALANCE_UPDATED);
 
+              const storedRoot2 = await ctx.views.getCommittedRoot(ctx.state.rootBBlockNum);
+              expect(storedRoot2).to.equal(rootB);
+
               const eb = BigInt(
                 await ctx.views.getEffectiveBalance(cluster.owner.address, cluster.operatorIds, cluster.cluster),
               );

test/ssv-fuzz-engine/eth-shared-operators.fuzz.ts

@@ -1,6 +1,7 @@
 import { expect } from "chai";
 import { fuzz, generateSeeds } from "./core/runner.ts";
 import { registerFuzzOperators, registerFuzzCluster, alignFee } from "./core/setup.ts";
+import { computeClusterBalance } from "./core/fuzz-helpers.ts";
 import type { OperatorRecord, ClusterRecord } from "./core/types.ts";
 import { parseClusterFromEvent } from "../helpers/cluster.ts";
 import { makePublicKey } from "../helpers/keys.ts";
@@ -124,6 +125,11 @@ describe("Fuzz: ETH shared operators — multiple clusters (CAT-2-8)", function
                 exclusiveBIndices, validatorCountB } = ctx.state;
               const thirdParty = ctx.signers[4];
 
+              const blockBefore = BigInt(await ctx.provider.getBlockNumber());
+              const balanceBBefore = BigInt(
+                await ctx.views.getBalance(clusterB.owner.address, clusterB.operatorIds, clusterB.cluster),
+              );
+
               const balance = BigInt(
                 await ctx.views.getBalance(clusterA.owner.address, clusterA.operatorIds, clusterA.cluster),
               );
@@ -169,10 +175,17 @@ describe("Fuzz: ETH shared operators — multiple clusters (CAT-2-8)", function
                 );
               }
 
+              const blockAfter = BigInt(await ctx.provider.getBlockNumber());
+              const opFeesB = [...sharedIndices, ...exclusiveBIndices].map(i => operators[i].fee);
+              const networkFee = BigInt(await ctx.views.getNetworkFee());
+              const expectedBalanceB = computeClusterBalance(
+                balanceBBefore, opFeesB, networkFee, BigInt(validatorCountB), blockAfter - blockBefore,
+              );
+
               const balanceB = BigInt(
                 await ctx.views.getBalance(clusterB.owner.address, clusterB.operatorIds, clusterB.cluster),
               );
-              expect(balanceB).to.be.greaterThan(0n, "Cluster B must still have balance");
+              expect(balanceB).to.equal(expectedBalanceB);
 
               const networkCount = BigInt(await ctx.views.getNetworkValidatorsCount());
               expect(networkCount).to.equal(expectedB);