Skip to content

Commit c9d8603

Browse files
fhennigmaltesander
andauthored
docs: improvements (#865)
* docs: improvements * fix whitespace * Apply suggestions from code review --------- Co-authored-by: Malte Sander <[email protected]>
1 parent 379ec15 commit c9d8603

File tree

11 files changed

+34
-29
lines changed

11 files changed

+34
-29
lines changed

docs/modules/zookeeper/pages/getting_started/first_steps.adoc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,15 @@ and apply it:
1414
[source,bash]
1515
include::example$getting_started/code/getting_started.sh[tag=install-zookeeper]
1616

17-
The operator will create a ZooKeeper cluster with two replicas.
17+
The operator creates a ZooKeeper cluster with two replicas.
1818
Use kubectl to observe the status of the cluster:
1919

2020
[source,bash]
2121
include::example$getting_started/code/getting_started.sh[tag=watch-zookeeper-rollout]
2222

23-
The Operator deploys readiness probes to make sure the replicas are ready and established a quorum.
24-
Only then will the StatefulSet actually be marked as `Ready`.
25-
You will see
23+
The operator deploys readiness probes to make sure the replicas are ready and established a quorum.
24+
Only then, the StatefulSet is actually marked as `Ready`.
25+
You see
2626

2727
----
2828
partitioned roll out complete: 2 new pods have been updated...
@@ -42,7 +42,7 @@ include::example$getting_started/code/getting_started.sh[tag=zkcli-ls]
4242
NOTE: You might wonder why the logs are used instead of the output from `kubectl run`.
4343
This is because `kubectl run` sometimes loses lines of the output, a link:https://github.com/kubernetes/kubernetes/issues/27264[known issue].
4444

45-
Among the log output you will see the current list of nodes in the root directory `/`:
45+
Among the log output you see the current list of nodes in the root directory `/`:
4646

4747
[source]
4848
----
@@ -82,7 +82,7 @@ Have a look at it using
8282
[source,bash]
8383
kubectl describe configmap simple-znode
8484

85-
You will see an output similar to this:
85+
You see an output similar to this:
8686

8787
[source]
8888
ZOOKEEPER:

docs/modules/zookeeper/pages/getting_started/index.adoc

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
11
= Getting started
22

3-
This guide will get you started with Apache ZooKeeper using the Stackable Operator. It will guide you through the installation of the Operator and its dependencies, setting up your first ZooKeeper cluster and connecting to it as well as setting up your first xref:znodes.adoc[ZNode].
3+
This guide gets you started with Apache ZooKeeper using the Stackable Operator.
4+
It guides you through the installation of the Operator and its dependencies, setting up your first ZooKeeper cluster and connecting to it as well as setting up your first xref:znodes.adoc[ZNode].
45

56
== Prerequisites
67

7-
You will need:
8+
You need:
89

910
* a Kubernetes cluster
1011
* kubectl
1112
* optional: Helm
1213

13-
Resource sizing depends on cluster type(s), usage and scope, but as a starting point we recommend a minimum of the following resources for this operator:
14+
Resource sizing depends on cluster type(s), usage and scope, but as a starting point a minimum of the following resources is recommended for this operator:
1415

1516
* 0.2 cores (e.g. i5 or similar)
1617
* 256MB RAM

docs/modules/zookeeper/pages/getting_started/installation.adoc

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,15 +2,15 @@
22
:description: Install the Stackable operator for Apache ZooKeeper using stackablectl or Helm.
33

44
There are multiple ways to install the Stackable Operator for Apache Zookeeper.
5-
`stackablectl` is the preferred way but Helm is also supported.
5+
xref:management:stackablectl:index.adoc[] is the preferred way, but Helm is also supported.
66
OpenShift users may prefer installing the operator from the RedHat Certified Operator catalog using the OpenShift web console.
77

88
[tabs]
99
====
1010
stackablectl (recommended)::
1111
+
1212
--
13-
`stackablectl` is the command line tool to interact with Stackable operators and our recommended way to install
13+
`stackablectl` is the command line tool to interact with Stackable operators and the recommended way to install
1414
Operators. Follow the xref:management:stackablectl:installation.adoc[installation steps] for your platform.
1515
1616
After you have installed `stackablectl`, use it to install the ZooKeeper Operator and its dependencies:
@@ -20,7 +20,7 @@ After you have installed `stackablectl`, use it to install the ZooKeeper Operato
2020
include::example$getting_started/code/getting_started.sh[tag=stackablectl-install-operators]
2121
----
2222
23-
The tool will show
23+
The tool prints
2424
2525
[source]
2626
include::example$getting_started/code/install_output.txt[]
@@ -32,7 +32,7 @@ example, you can use the `--cluster kind` flag to create a Kubernetes cluster wi
3232
Helm::
3333
+
3434
--
35-
You can also use Helm to install the Operators.
35+
You can also use Helm to install the operators.
3636
Add the Stackable Helm repository:
3737
[source,bash]
3838
----

docs/modules/zookeeper/pages/index.adoc

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ Within the Stackable Platform, the Stackable operators for xref:hbase:index.adoc
2020

2121
== Getting started
2222

23-
Get started with Apache ZooKeeper and the Stackable operator by following the xref:getting_started/index.adoc[Getting started] guide, it will guide you through the xref:getting_started/installation.adoc[installation] process.
24-
Afterwards, consult the xref:usage_guide/index.adoc[Usage guide] to learn more about configuring ZooKeeper for your needs.
23+
Get started with Apache ZooKeeper and the Stackable operator by following the xref:getting_started/index.adoc[Getting started] guide, it guides you through the xref:getting_started/installation.adoc[installation] process.
24+
Afterward, consult the xref:usage_guide/index.adoc[Usage guide] to learn more about configuring ZooKeeper for your needs.
2525
You can also deploy a <<demos, demo>> to see an example deployment of ZooKeeper together with other data products.
2626

2727
== Operator model
@@ -45,7 +45,7 @@ Apache ZooKeeper and the Stackable operator have no dependencies besides the xre
4545

4646
== [[demos]]Demos
4747

48-
Apache ZooKeeper is a dependency of xref:hbase:index.adoc[Apache HBase], xref:hdfs:index.adoc[Apache Hadoop HDFS], xref:kafka:index.adoc[Apache Kafka] and xref:nifi:index.adoc[Apache NiFi], thus any demo that uses one or more of these components will also deploy a ZooKeeper ensemble.
48+
Apache ZooKeeper is a dependency of xref:hbase:index.adoc[Apache HBase], xref:hdfs:index.adoc[Apache Hadoop HDFS], xref:kafka:index.adoc[Apache Kafka] and xref:nifi:index.adoc[Apache NiFi], thus any demo that uses one or more of these components also deploys a ZooKeeper ensemble.
4949
Here is the list of the demos that include ZooKeeper:
5050

5151
* xref:demos:data-lakehouse-iceberg-trino-spark.adoc[]

docs/modules/zookeeper/pages/reference/commandline-parameters.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ cargo run -- run --product-config /foo/bar/properties.yaml
2323

2424
*Multiple values:* false
2525

26-
The operator will **only** watch for resources in the provided namespace `test`:
26+
The operator **only** watches for resources in the provided namespace `test`:
2727

2828
[source]
2929
----

docs/modules/zookeeper/pages/reference/environment-variables.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ docker run \
3636

3737
*Multiple values:* false
3838

39-
The operator will **only** watch for resources in the provided namespace `test`:
39+
The operator **only** watches for resources in the provided namespace `test`:
4040

4141
[source]
4242
----

docs/modules/zookeeper/pages/usage_guide/authentication.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ include::example$usage_guide/example-cluster-tls-authentication-secret.yaml[]
2020
<4> The SecretClass that is referenced by the AuthenticationClass in order to provide certificates.
2121

2222
If both `spec.clusterConfig.tls.server.secretClass` and `spec.clusterConfig.authentication.authenticationClass` are set,
23-
the authentication class will take precedence over the secret class. The cluster will be encrypted and authenticate only
24-
against the authentication class.
23+
the authentication class takes precedence over the secret class.
24+
The cluster is encrypted and authenticates only against the authentication class.
2525

2626
WARNING: Due to a https://issues.apache.org/jira/browse/ZOOKEEPER-4276[bug] in ZooKeeper, the `clientPort` property in
2727
combination with `client.portUnification=true` is used instead of the `secureClientPort`. This means that unencrypted

docs/modules/zookeeper/pages/usage_guide/configuration_environment_overrides.adoc

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,13 +39,16 @@ servers:
3939

4040
All property values must be strings.
4141

42-
For a full list of configuration options we refer to the Apache ZooKeeper https://zookeeper.apache.org/doc/r3.9.2/zookeeperAdmin.html#sc_configuration[Configuration Reference].
42+
For a full list of configuration options refer to the Apache ZooKeeper https://zookeeper.apache.org/doc/r3.9.2/zookeeperAdmin.html#sc_configuration[Configuration Reference].
4343

4444
=== Overriding entries in security.properties
4545

4646
The `security.properties` file is used to configure JVM security properties. It is very seldom that users need to tweak any of these, but there is one use-case that stands out, and that users need to be aware of: the JVM DNS cache.
4747

48-
The JVM manages its own cache of successfully resolved host names as well as a cache of host names that cannot be resolved. Some products of the Stackable platform are very sensible to the contents of these caches and their performance is heavily affected by them. As of version 3.8.1, Apache ZooKeeper always requires up-to-date IP addresses to maintain its quorum. To guarantee this, the negative DNS cache of the JVM needs to be disabled. This can be achieved by setting the TTL of entries in the negative cache to zero, like this:
48+
The JVM manages its own cache of successfully resolved host names as well as a cache of host names that cannot be resolved.
49+
Some products of the Stackable platform are very sensible to the contents of these caches and their performance is heavily affected by them.
50+
As of version 3.8.1, Apache ZooKeeper always requires up-to-date IP addresses to maintain its quorum.
51+
To guarantee this, the negative DNS cache of the JVM needs to be disabled. This can be achieved by setting the TTL of entries in the negative cache to zero, like this:
4952

5053
[source,yaml]
5154
----

docs/modules/zookeeper/pages/usage_guide/isolating_clients_with_znodes.adoc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -57,14 +57,14 @@ In this example, two ConfigMaps are created:
5757

5858
=== Connecting the products to the ZNodes
5959

60-
The ConfigMaps with the name and namespaces as given above will look similar to this:
60+
The ConfigMaps with the name and namespaces as given above look similar to this:
6161

6262
[source,yaml]
6363
----
6464
include::example$usage_guide/znode/example-znode-discovery.yaml[]
6565
----
6666
<1> Name and namespaces as specified above
67-
<2> `$PATH` will be a unique and unpredictable path that is generated by the operator
67+
<2> `$PATH` is a unique and unpredictable path that is generated by the operator
6868

6969
This ConfigMap can then be mounted into other Pods and the `ZOOKEEPER` key can be used to connect to the ZooKeeper instance and the correct ZNode.
7070

docs/modules/zookeeper/pages/usage_guide/operations/index.adoc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
This section of the documentation is intended for the operations teams that maintain a Stackable Data Platform installation.
44

5-
Please read on the xref:concepts:operations/index.adoc[Concepts page on Operations] with the necessary details to operate the platform in a production environment.
5+
Read on the xref:concepts:operations/index.adoc[concepts page on operations] with the necessary details to operate the platform in a production environment.

0 commit comments

Comments
 (0)