Skip to content

Commit 7624fb6

Browse files
authored
feat(deps): use go 1.24 tool feature to install golangci-lint (#709)
relates to STACKITCLI-178
1 parent fdb5bc6 commit 7624fb6

File tree

8 files changed

+1032
-64
lines changed

8 files changed

+1032
-64
lines changed

.github/actions/build/action.yaml

Lines changed: 0 additions & 16 deletions
This file was deleted.

.github/workflows/ci.yaml

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,6 @@ name: CI
22

33
on: [pull_request, workflow_dispatch]
44

5-
env:
6-
GO_VERSION: "1.24"
7-
85
jobs:
96
main:
107
name: CI
@@ -13,11 +10,12 @@ jobs:
1310
- name: Checkout
1411
uses: actions/checkout@v4
1512

16-
- name: Build
17-
uses: ./.github/actions/build
13+
- name: Install go
14+
uses: actions/setup-go@v5
1815
with:
19-
go-version: ${{ env.GO_VERSION }}
20-
16+
go-version-file: "go.mod"
17+
cache: true
18+
2119
- name: "Ensure docs are up-to-date"
2220
if: ${{ github.event_name == 'pull_request' }}
2321
run: ./scripts/check-docs.sh

.github/workflows/release.yaml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,13 @@ jobs:
2525
AWS_ACCESS_KEY_ID: ${{ secrets.OBJECT_STORAGE_ACCESS_KEY_ID }}
2626
AWS_SECRET_ACCESS_KEY: ${{ secrets.OBJECT_STORAGE_SECRET_ACCESS_KEY }}
2727
steps:
28-
- uses: actions/checkout@v4
28+
- name: Checkout
29+
uses: actions/checkout@v4
2930
with:
3031
# Allow goreleaser to access older tag information.
3132
fetch-depth: 0
32-
- uses: actions/setup-go@v5
33+
- name: Install go
34+
uses: actions/setup-go@v5
3335
with:
3436
go-version-file: "go.mod"
3537
cache: true

CONTRIBUTION.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ Prerequisites:
2626

2727
These commands can be executed from the project root:
2828

29-
- `make project-tools`: install the required dependencies
3029
- `make build`: compile the CLI and save the binary under _./bin/stackit_
3130
- `make lint`: lint the code
3231
- `make generate-docs`: generate Markdown documentation for every command

Makefile

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,10 @@ build:
1010
fmt:
1111
@gofmt -s -w .
1212

13-
# Setup and tool initialization tasks
14-
project-help:
15-
@$(SCRIPTS_BASE)/project.sh help
16-
17-
project-tools:
18-
@$(SCRIPTS_BASE)/project.sh tools
19-
2013
# Lint
2114
lint-golangci-lint:
2215
@echo ">> Linting with golangci-lint"
23-
@golangci-lint run ${GOLANG_CI_ARGS}
16+
@go tool golangci-lint run ${GOLANG_CI_ARGS}
2417

2518
lint-yamllint:
2619
@echo ">> Linting with yamllint"

go.mod

Lines changed: 161 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,18 +42,175 @@ require (
4242
)
4343

4444
require (
45-
golang.org/x/net v0.33.0 // indirect
46-
golang.org/x/time v0.8.0 // indirect
45+
golang.org/x/net v0.37.0 // indirect
46+
golang.org/x/time v0.10.0 // indirect
4747
gopkg.in/inf.v0 v0.9.1 // indirect
4848
)
4949

5050
require (
51+
4d63.com/gocheckcompilerdirectives v1.3.0 // indirect
52+
4d63.com/gochecknoglobals v0.2.2 // indirect
5153
al.essio.dev/pkg/shellescape v1.5.1 // indirect
54+
github.com/4meepo/tagalign v1.4.2 // indirect
55+
github.com/Abirdcfly/dupword v0.1.3 // indirect
56+
github.com/Antonboom/errname v1.0.0 // indirect
57+
github.com/Antonboom/nilnil v1.0.1 // indirect
58+
github.com/Antonboom/testifylint v1.5.2 // indirect
59+
github.com/BurntSushi/toml v1.4.1-0.20240526193622-a339e1f7089c // indirect
60+
github.com/Crocmagnon/fatcontext v0.7.1 // indirect
61+
github.com/Djarvur/go-err113 v0.0.0-20210108212216-aea10b59be24 // indirect
62+
github.com/GaijinEntertainment/go-exhaustruct/v3 v3.3.1 // indirect
63+
github.com/Masterminds/semver/v3 v3.3.0 // indirect
64+
github.com/OpenPeeDeeP/depguard/v2 v2.2.1 // indirect
65+
github.com/alecthomas/go-check-sumtype v0.3.1 // indirect
66+
github.com/alexkohler/nakedret/v2 v2.0.5 // indirect
67+
github.com/alexkohler/prealloc v1.0.0 // indirect
68+
github.com/alingse/asasalint v0.0.11 // indirect
69+
github.com/alingse/nilnesserr v0.1.2 // indirect
70+
github.com/ashanbrown/forbidigo v1.6.0 // indirect
71+
github.com/ashanbrown/makezero v1.2.0 // indirect
72+
github.com/beorn7/perks v1.0.1 // indirect
73+
github.com/bkielbasa/cyclop v1.2.3 // indirect
74+
github.com/blizzy78/varnamelen v0.8.0 // indirect
75+
github.com/bombsimon/wsl/v4 v4.5.0 // indirect
76+
github.com/breml/bidichk v0.3.2 // indirect
77+
github.com/breml/errchkjson v0.4.0 // indirect
78+
github.com/butuzov/ireturn v0.3.1 // indirect
79+
github.com/butuzov/mirror v1.3.0 // indirect
80+
github.com/catenacyber/perfsprint v0.8.2 // indirect
81+
github.com/ccojocar/zxcvbn-go v1.0.2 // indirect
82+
github.com/cespare/xxhash/v2 v2.3.0 // indirect
83+
github.com/charithe/durationcheck v0.0.10 // indirect
84+
github.com/chavacava/garif v0.1.0 // indirect
85+
github.com/ckaznocha/intrange v0.3.0 // indirect
86+
github.com/curioswitch/go-reassign v0.3.0 // indirect
87+
github.com/daixiang0/gci v0.13.5 // indirect
88+
github.com/denis-tingaikin/go-header v0.5.0 // indirect
89+
github.com/ettle/strcase v0.2.0 // indirect
90+
github.com/fatih/structtag v1.2.0 // indirect
91+
github.com/firefart/nonamedreturns v1.0.5 // indirect
5292
github.com/fxamacker/cbor/v2 v2.7.0 // indirect
93+
github.com/fzipp/gocyclo v0.6.0 // indirect
94+
github.com/ghostiam/protogetter v0.3.9 // indirect
95+
github.com/go-critic/go-critic v0.12.0 // indirect
96+
github.com/go-toolsmith/astcast v1.1.0 // indirect
97+
github.com/go-toolsmith/astcopy v1.1.0 // indirect
98+
github.com/go-toolsmith/astequal v1.2.0 // indirect
99+
github.com/go-toolsmith/astfmt v1.1.0 // indirect
100+
github.com/go-toolsmith/astp v1.1.0 // indirect
101+
github.com/go-toolsmith/strparse v1.1.0 // indirect
102+
github.com/go-toolsmith/typep v1.1.0 // indirect
53103
github.com/go-viper/mapstructure/v2 v2.2.1 // indirect
104+
github.com/go-xmlfmt/xmlfmt v1.1.3 // indirect
105+
github.com/gobwas/glob v0.2.3 // indirect
106+
github.com/gofrs/flock v0.12.1 // indirect
107+
github.com/golang/protobuf v1.5.4 // indirect
108+
github.com/golangci/dupl v0.0.0-20250308024227-f665c8d69b32 // indirect
109+
github.com/golangci/go-printf-func-name v0.1.0 // indirect
110+
github.com/golangci/gofmt v0.0.0-20250106114630-d62b90e6713d // indirect
111+
github.com/golangci/golangci-lint v1.64.8 // indirect
112+
github.com/golangci/misspell v0.6.0 // indirect
113+
github.com/golangci/plugin-module-register v0.1.1 // indirect
114+
github.com/golangci/revgrep v0.8.0 // indirect
115+
github.com/golangci/unconvert v0.0.0-20240309020433-c5143eacb3ed // indirect
116+
github.com/gordonklaus/ineffassign v0.1.0 // indirect
117+
github.com/gostaticanalysis/analysisutil v0.7.1 // indirect
118+
github.com/gostaticanalysis/comment v1.5.0 // indirect
119+
github.com/gostaticanalysis/forcetypeassert v0.2.0 // indirect
120+
github.com/gostaticanalysis/nilerr v0.1.1 // indirect
121+
github.com/hashicorp/go-immutable-radix/v2 v2.1.0 // indirect
122+
github.com/hashicorp/go-version v1.7.0 // indirect
123+
github.com/hashicorp/golang-lru/v2 v2.0.7 // indirect
124+
github.com/hexops/gotextdiff v1.0.3 // indirect
125+
github.com/jgautheron/goconst v1.7.1 // indirect
126+
github.com/jingyugao/rowserrcheck v1.1.1 // indirect
127+
github.com/jjti/go-spancheck v0.6.4 // indirect
128+
github.com/julz/importas v0.2.0 // indirect
129+
github.com/karamaru-alpha/copyloopvar v1.2.1 // indirect
130+
github.com/kisielk/errcheck v1.9.0 // indirect
131+
github.com/kkHAIKE/contextcheck v1.1.6 // indirect
132+
github.com/kulti/thelper v0.6.3 // indirect
133+
github.com/kunwardeep/paralleltest v1.0.10 // indirect
134+
github.com/lasiar/canonicalheader v1.1.2 // indirect
135+
github.com/ldez/exptostd v0.4.2 // indirect
136+
github.com/ldez/gomoddirectives v0.6.1 // indirect
137+
github.com/ldez/grignotin v0.9.0 // indirect
138+
github.com/ldez/tagliatelle v0.7.1 // indirect
139+
github.com/ldez/usetesting v0.4.2 // indirect
140+
github.com/leonklingele/grouper v1.1.2 // indirect
141+
github.com/macabu/inamedparam v0.1.3 // indirect
142+
github.com/maratori/testableexamples v1.0.0 // indirect
143+
github.com/maratori/testpackage v1.1.1 // indirect
144+
github.com/matoous/godox v1.1.0 // indirect
54145
github.com/mattn/go-isatty v0.0.20 // indirect
146+
github.com/matttproud/golang_protobuf_extensions v1.0.1 // indirect
147+
github.com/mgechev/revive v1.7.0 // indirect
148+
github.com/mitchellh/go-homedir v1.1.0 // indirect
149+
github.com/moricho/tparallel v0.3.2 // indirect
55150
github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect
151+
github.com/nakabonne/nestif v0.3.1 // indirect
152+
github.com/nishanths/exhaustive v0.12.0 // indirect
153+
github.com/nishanths/predeclared v0.2.2 // indirect
154+
github.com/nunnatsa/ginkgolinter v0.19.1 // indirect
155+
github.com/olekukonko/tablewriter v0.0.5 // indirect
156+
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
157+
github.com/polyfloyd/go-errorlint v1.7.1 // indirect
158+
github.com/prometheus/client_golang v1.12.1 // indirect
159+
github.com/prometheus/client_model v0.2.0 // indirect
160+
github.com/prometheus/common v0.32.1 // indirect
161+
github.com/prometheus/procfs v0.7.3 // indirect
162+
github.com/quasilyte/go-ruleguard v0.4.3-0.20240823090925-0fe6f58b47b1 // indirect
163+
github.com/quasilyte/go-ruleguard/dsl v0.3.22 // indirect
164+
github.com/quasilyte/gogrep v0.5.0 // indirect
165+
github.com/quasilyte/regex/syntax v0.0.0-20210819130434-b3f0c404a727 // indirect
166+
github.com/quasilyte/stdinfo v0.0.0-20220114132959-f7386bf02567 // indirect
167+
github.com/raeperd/recvcheck v0.2.0 // indirect
168+
github.com/rogpeppe/go-internal v1.14.1 // indirect
169+
github.com/ryancurrah/gomodguard v1.3.5 // indirect
170+
github.com/ryanrolds/sqlclosecheck v0.5.1 // indirect
171+
github.com/sanposhiho/wastedassign/v2 v2.1.0 // indirect
172+
github.com/santhosh-tekuri/jsonschema/v6 v6.0.1 // indirect
173+
github.com/sashamelentyev/interfacebloat v1.1.0 // indirect
174+
github.com/sashamelentyev/usestdlibvars v1.28.0 // indirect
175+
github.com/securego/gosec/v2 v2.22.2 // indirect
176+
github.com/sirupsen/logrus v1.9.3 // indirect
177+
github.com/sivchari/containedctx v1.0.3 // indirect
178+
github.com/sivchari/tenv v1.12.1 // indirect
179+
github.com/sonatard/noctx v0.1.0 // indirect
180+
github.com/sourcegraph/go-diff v0.7.0 // indirect
181+
github.com/ssgreg/nlreturn/v2 v2.2.1 // indirect
182+
github.com/stbenjam/no-sprintf-host-port v0.2.0 // indirect
183+
github.com/stretchr/objx v0.5.2 // indirect
184+
github.com/stretchr/testify v1.10.0 // indirect
185+
github.com/tdakkota/asciicheck v0.4.1 // indirect
186+
github.com/tetafro/godot v1.5.0 // indirect
187+
github.com/timakin/bodyclose v0.0.0-20241017074812-ed6a65f985e3 // indirect
188+
github.com/timonwong/loggercheck v0.10.1 // indirect
189+
github.com/tomarrell/wrapcheck/v2 v2.10.0 // indirect
190+
github.com/tommy-muehle/go-mnd/v2 v2.5.1 // indirect
191+
github.com/ultraware/funlen v0.2.0 // indirect
192+
github.com/ultraware/whitespace v0.2.0 // indirect
193+
github.com/uudashr/gocognit v1.2.0 // indirect
194+
github.com/uudashr/iface v1.3.1 // indirect
56195
github.com/x448/float16 v0.8.4 // indirect
196+
github.com/xen0n/gosmopolitan v1.2.2 // indirect
197+
github.com/yagipy/maintidx v1.0.0 // indirect
198+
github.com/yeya24/promlinter v0.3.0 // indirect
199+
github.com/ykadowak/zerologlint v0.1.5 // indirect
200+
gitlab.com/bosi/decorder v0.4.2 // indirect
201+
go-simpler.org/musttag v0.13.0 // indirect
202+
go-simpler.org/sloglint v0.9.0 // indirect
203+
go.uber.org/atomic v1.9.0 // indirect
204+
go.uber.org/automaxprocs v1.6.0 // indirect
205+
go.uber.org/zap v1.24.0 // indirect
206+
golang.org/x/exp/typeparams v0.0.0-20250210185358-939b2ce775ac // indirect
207+
golang.org/x/sync v0.13.0 // indirect
208+
golang.org/x/tools v0.31.0 // indirect
209+
google.golang.org/protobuf v1.36.5 // indirect
210+
gopkg.in/yaml.v2 v2.4.0 // indirect
211+
honnef.co/go/tools v0.6.1 // indirect
212+
mvdan.cc/gofumpt v0.7.0 // indirect
213+
mvdan.cc/unparam v0.0.0-20240528143540-8a5130ca722f // indirect
57214
)
58215

59216
require (
@@ -95,3 +252,5 @@ require (
95252
sigs.k8s.io/structured-merge-diff/v4 v4.4.2 // indirect
96253
sigs.k8s.io/yaml v1.4.0 // indirect
97254
)
255+
256+
tool github.com/golangci/golangci-lint/cmd/golangci-lint

0 commit comments

Comments
 (0)