Skip to content

Commit 5c1bd31

Browse files
committed
ignoring security_group_id lifecycle now since value is not being known before and checking them in the acc test correctly now
1 parent f65cbea commit 5c1bd31

File tree

3 files changed

+25
-11
lines changed

3 files changed

+25
-11
lines changed

stackit/internal/services/loadbalancer/loadbalancer_acc_test.go

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ func TestAccLoadBalancerResourceMin(t *testing.T) {
180180
resource.TestCheckResourceAttrSet("data.stackit_loadbalancer.loadbalancer", "security_group_id"),
181181
resource.TestCheckResourceAttrPair(
182182
"stackit_loadbalancer.loadbalancer", "security_group_id",
183-
"data.stackit_security_group.security_group", "security_group_id",
183+
"data.stackit_loadbalancer.loadbalancer", "security_group_id",
184184
),
185185
)},
186186
// Import
@@ -196,8 +196,11 @@ func TestAccLoadBalancerResourceMin(t *testing.T) {
196196
if !ok {
197197
return "", fmt.Errorf("couldn't find attribute name")
198198
}
199-
200-
return fmt.Sprintf("%s,%s,%s", testutil.ProjectId, testutil.Region, name), nil
199+
region, ok := r.Primary.Attributes["region"]
200+
if !ok {
201+
return "", fmt.Errorf("couldn't find attribute region")
202+
}
203+
return fmt.Sprintf("%s,%s,%s", testutil.ProjectId, region, name), nil
201204
},
202205
ImportState: true,
203206
ImportStateVerify: true,
@@ -317,10 +320,6 @@ func TestAccLoadBalancerResourceMax(t *testing.T) {
317320
resource.TestCheckResourceAttrSet("data.stackit_loadbalancer.loadbalancer", "external_address"),
318321
resource.TestCheckResourceAttr("data.stackit_loadbalancer.loadbalancer", "disable_security_group_assignment", testutil.ConvertConfigVariable(testConfigVarsMax["disable_security_group_assignment"])),
319322
resource.TestCheckResourceAttrSet("stackit_loadbalancer.loadbalancer", "security_group_id"),
320-
resource.TestCheckResourceAttrPair(
321-
"stackit_loadbalancer.loadbalancer", "security_group_id",
322-
"data.stackit_security_group.security_group", "security_group_id",
323-
),
324323
resource.TestCheckResourceAttr("data.stackit_loadbalancer.loadbalancer", "target_pools.0.active_health_check.healthy_threshold", testutil.ConvertConfigVariable(testConfigVarsMax["healthy_threshold"])),
325324
resource.TestCheckResourceAttr("data.stackit_loadbalancer.loadbalancer", "target_pools.0.active_health_check.interval", testutil.ConvertConfigVariable(testConfigVarsMax["health_interval"])),
326325
resource.TestCheckResourceAttr("data.stackit_loadbalancer.loadbalancer", "target_pools.0.active_health_check.interval_jitter", testutil.ConvertConfigVariable(testConfigVarsMax["health_interval_jitter"])),
@@ -334,6 +333,10 @@ func TestAccLoadBalancerResourceMax(t *testing.T) {
334333
resource.TestCheckResourceAttrSet("data.stackit_loadbalancer.loadbalancer", "options.observability.metrics.credentials_ref"),
335334
resource.TestCheckResourceAttrPair("stackit_loadbalancer_observability_credential.metrics", "credentials_ref", "data.stackit_loadbalancer.loadbalancer", "options.observability.metrics.credentials_ref"),
336335
resource.TestCheckResourceAttr("data.stackit_loadbalancer.loadbalancer", "options.observability.metrics.push_url", testutil.ConvertConfigVariable(testConfigVarsMax["observability_metrics_push_url"])),
336+
resource.TestCheckResourceAttrPair(
337+
"stackit_loadbalancer.loadbalancer", "security_group_id",
338+
"data.stackit_loadbalancer.loadbalancer", "security_group_id",
339+
),
337340
)},
338341
// Import
339342
{
@@ -348,8 +351,11 @@ func TestAccLoadBalancerResourceMax(t *testing.T) {
348351
if !ok {
349352
return "", fmt.Errorf("couldn't find attribute name")
350353
}
351-
352-
return fmt.Sprintf("%s,%s,%s", testutil.ProjectId, testutil.Region, name), nil
354+
region, ok := r.Primary.Attributes["region"]
355+
if !ok {
356+
return "", fmt.Errorf("couldn't find attribute region")
357+
}
358+
return fmt.Sprintf("%s,%s,%s", testutil.ProjectId, region, name), nil
353359
},
354360
ImportState: true,
355361
ImportStateVerify: true,

stackit/internal/services/loadbalancer/testfiles/resource-max.tf

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ variable "listener_port" {}
1212
variable "listener_protocol" {}
1313
variable "network_role" {}
1414
variable "disable_security_group_assignment" {}
15-
variable "security_group_id" {}
1615

1716
variable "listener_display_name" {}
1817
variable "listener_server_name_indicators" {}
@@ -46,7 +45,11 @@ resource "stackit_network_interface" "network_interface" {
4645
project_id = stackit_network.network.project_id
4746
network_id = stackit_network.network.network_id
4847
name = "name"
49-
security_group_id = var.security_group_id
48+
lifecycle {
49+
ignore_changes = [
50+
security_group_ids,
51+
]
52+
}
5053
}
5154

5255
resource "stackit_public_ip" "public_ip" {

stackit/internal/services/loadbalancer/testfiles/resource-min.tf

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ resource "stackit_network_interface" "network_interface" {
2727
project_id = stackit_network.network.project_id
2828
network_id = stackit_network.network.network_id
2929
name = "name"
30+
lifecycle {
31+
ignore_changes = [
32+
security_group_ids,
33+
]
34+
}
3035
}
3136

3237
resource "stackit_public_ip" "public_ip" {

0 commit comments

Comments
 (0)