Skip to content

fix(observability): remove invalid fields match and match_regex from main route in alert_config #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 12, 2025
Merged

fix(observability): remove invalid fields match and match_regex from main route in alert_config #915

merged 5 commits into from
Sep 12, 2025

Conversation

@marceljk
Copy link
Contributor

@marceljk marceljk commented Jul 17, 2025 •
edited
Loading

Description

relates to STACKITTPR-226 and #784

  • removed invalid fields match and match_regex from main route in alert_config
  • deprecated match and match_regex in child routes
  • add new matchers field

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch from 078d4fd to 0ebcb10 Compare July 28, 2025 07:54
@github-actions
Copy link

github-actions bot commented Aug 5, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 5, 2025
@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch from 0ebcb10 to 45f2347 Compare August 5, 2025 07:06
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Aug 5, 2025
@github-actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 13, 2025
@haeussermanp haeussermanp mentioned this pull request Aug 13, 2025
Open
@haeussermanp
Copy link

Hi, why is it on hold? Just a new comment so it would not be removed. 😄

@Fyusel Fyusel removed the Stale PR is marked as stale due to inactivity. label Aug 13, 2025
@marceljk
Copy link
Contributor Author

Hi, why is it on hold? Just a new comment so it would not be removed. 😄

Hi @haeussermanp, there is an API issue the set matchers doesn't return on a GET request. This results in an error in the terraform provider.
This issue is already reported to the Observability Team.

When this is fixed, the PR is ready for review 😄

@github-actions
Copy link

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Aug 22, 2025
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Aug 25, 2025
@github-actions
Copy link

github-actions bot commented Sep 2, 2025

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Sep 2, 2025
@marceljk marceljk removed the Stale PR is marked as stale due to inactivity. label Sep 2, 2025
@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch 2 times, most recently from c5d7ddd to bee5272 Compare September 9, 2025 11:43
@marceljk marceljk marked this pull request as ready for review September 10, 2025 13:40
@marceljk marceljk requested a review from a team as a code owner September 10, 2025 13:40
@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch 2 times, most recently from df189dd to c5950e0 Compare September 10, 2025 14:42
Fyusel
Fyusel reviewed Sep 12, 2025
View reviewed changes
@marceljk marceljk force-pushed the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch from 5ba29d4 to 6bbbf2a Compare September 12, 2025 07:55
@marceljk marceljk enabled auto-merge (squash) September 12, 2025 07:55
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance 38.45% (+0.37%) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil 7.38% (+1.54%) 👍
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/datasource.go 0.00% (ø) 78 0 78
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource.go 42.08% (+0.37%) 827 (+7) 348 (+6) 479 (+1) 👍
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil/testutil.go 7.38% (+1.54%) 122 (+2) 9 (+2) 113 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/instance/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/observability/observability_acc_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/testutil/testutil_test.go

@marceljk marceljk merged commit 65c6106 into main Sep 12, 2025
5 checks passed
@marceljk marceljk deleted the fix/STACKITTPR-226-observability-creation-with-matchers-fails branch September 12, 2025 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fyusel Fyusel Fyusel approved these changes

Assignees

No one assigned

Labels

on-hold

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marceljk @haeussermanp @Fyusel @rubenhoenle