Document read-only root filesystem default - #1100
Merged
Merged
Conversation
Explain the operator default, writable volume patterns, and the explicit pod template override.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Documents the ToolHive Kubernetes operator’s default readOnlyRootFilesystem: true setting for the mcp container, and shows how to keep that default while still providing writable paths via volumes (plus how to override it when an image requires a writable root filesystem).
Changes:
- Updates the “Mount a volume” guidance to explicitly document the operator’s default read-only root filesystem behavior.
- Adds a persistent PVC example for writable data paths and an
emptyDirexample for writable ephemeral paths like/tmp. - Adds a
podTemplateSpecexample for explicitly disablingreadOnlyRootFilesystemwhen required, with a recommendation to prefer writable mounts instead.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
danbarr
marked this pull request as ready for review
August 14, 2026 16:21
danbarr
enabled auto-merge (squash)
August 14, 2026 16:46
JAORMX
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document the Kubernetes operator's default read-only root filesystem for MCP server containers. Add examples for writable persistent and ephemeral volumes, and show the explicit pod template override for images that require a writable root filesystem.
Type of change
Related issues/PRs
Closes #1080
Screenshots
Not applicable.
Submitter checklist
Content and formatting
Reviewer checklist
Content