Skip to content

Conversation

@Stringy
Copy link
Contributor

@Stringy Stringy commented Sep 1, 2025

Description

Adds ARM support to Fact, including multi-arch upstream builds and testing.

  • fcarm VMs added to integration testing.
  • arch-specific vmlinux added (arm vmlinux generated from fedora-coreos arm VM).
  • minor changes to build script and event parsing.

Downstream (konflux) changes to follow.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Testing Performed

Manually spun up arm Fact on a Fedora CoreOS machine to verify the returned events, otherwise relying on CI tests.

@Stringy Stringy force-pushed the giles/ROX-30260-arm-support branch from 7640c01 to 9b38ca6 Compare September 1, 2025 15:03
@Stringy Stringy force-pushed the giles/ROX-30260-arm-support branch from 3915ff5 to b7319a4 Compare September 2, 2025 08:50
@Stringy Stringy changed the title ROX-30260: add support for arm64 ROX-30260: add upstream support for arm64 Sep 2, 2025
@Stringy Stringy changed the title ROX-30260: add upstream support for arm64 ROX-30260: add support for arm64 [upstream] Sep 2, 2025
@Stringy Stringy marked this pull request as ready for review September 2, 2025 09:44
type: string
default: ''

# this is temporary, will be removed once Konflux builds have been
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to revert this hacky thing the moment I create the new branch to add arm support to the konflux builds. It's only here because merging this PR with broken konflux would be a Bad Thing™️ , and we don't need it once everything supports arm

@Stringy
Copy link
Contributor Author

Stringy commented Sep 2, 2025

I'm sure we'd fixed the GCP zone capacity issues already, but seems that it's still a problem. I'm not sure there's much we can do about it from this repo, however.

Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this one, just left a few comments but mostly LGTM!

@Molter73
Copy link
Collaborator

Molter73 commented Sep 2, 2025

I'm sure we'd fixed the GCP zone capacity issues already, but seems that it's still a problem. I'm not sure there's much we can do about it from this repo, however.

We did and we didn't: stackrox/collector#2358 (comment)

I'm not 100% sure how we could address the problem in ansible on the collector repo, since that solution seems hacky and I can't think of a better solution.

@Stringy Stringy force-pushed the giles/ROX-30260-arm-support branch 2 times, most recently from 23dc015 to 916a11b Compare September 2, 2025 10:31
Co-authored-by: Mauro Ezequiel Moltrasio <[email protected]>
@Stringy Stringy force-pushed the giles/ROX-30260-arm-support branch from 916a11b to 81f44de Compare September 2, 2025 10:33
Copy link
Collaborator

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Provided CI passes we can go ahead and merge.

@Stringy Stringy merged commit 482bf79 into main Sep 2, 2025
16 of 17 checks passed
@Stringy Stringy deleted the giles/ROX-30260-arm-support branch September 2, 2025 10:51
@Molter73 Molter73 mentioned this pull request Sep 3, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants