-
Notifications
You must be signed in to change notification settings - Fork 1
ROX-30260: add support for arm64 [upstream] #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
7640c01 to
9b38ca6
Compare
3915ff5 to
b7319a4
Compare
| type: string | ||
| default: '' | ||
|
|
||
| # this is temporary, will be removed once Konflux builds have been |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to revert this hacky thing the moment I create the new branch to add arm support to the konflux builds. It's only here because merging this PR with broken konflux would be a Bad Thing™️ , and we don't need it once everything supports arm
|
I'm sure we'd fixed the GCP zone capacity issues already, but seems that it's still a problem. I'm not sure there's much we can do about it from this repo, however. |
Molter73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this one, just left a few comments but mostly LGTM!
We did and we didn't: stackrox/collector#2358 (comment) I'm not 100% sure how we could address the problem in ansible on the collector repo, since that solution seems hacky and I can't think of a better solution. |
23dc015 to
916a11b
Compare
Co-authored-by: Mauro Ezequiel Moltrasio <[email protected]>
916a11b to
81f44de
Compare
Molter73
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Provided CI passes we can go ahead and merge.
Description
Adds ARM support to Fact, including multi-arch upstream builds and testing.
Downstream (konflux) changes to follow.
Checklist
Testing Performed
Manually spun up arm Fact on a Fedora CoreOS machine to verify the returned events, otherwise relying on CI tests.