Skip to content

Commit 202724b

Browse files
meorphismeorphis
andauthored
fix: sort regressions first when determining worst outcome (#214)
Co-authored-by: meorphis <eric@stainless.com>
1 parent 1ae0234 commit 202724b

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

dist/build.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/merge.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/preview.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/outcomes.ts

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -232,9 +232,14 @@ export function categorizeOutcome({
232232
.filter((r): r is Exclude<typeof categoryOutcome, null> => r !== null)
233233
.sort(
234234
(a, b) =>
235-
// sort by severity then rank
235+
// sort by regression status then severity then rank
236+
(!(a.severity === "fatal" || b.severity === "fatal")
237+
? [true, null, false].indexOf(a.isRegression) -
238+
[true, null, false].indexOf(b.isRegression)
239+
: 0) ||
236240
conclusions.diagnostic.indexOf(a.severity) -
237-
conclusions.diagnostic.indexOf(b.severity) || a.rank - b.rank,
241+
conclusions.diagnostic.indexOf(b.severity) ||
242+
a.rank - b.rank,
238243
)[0];
239244

240245
return {

0 commit comments

Comments
 (0)